fix(core): Validate customData keys and values

[valya]

Throws errors in manual mode and ignores and logs values in production

Github issue / Community forum post (link here to close automatically):

[github-actions]

Great PR! Please pay attention to the following items before merging:

Files matching packages/**:

• If fixing bug, added test to cover scenario.
• If addressing forum or Github issue, added link to description.

Files matching packages/**/*.ts:

• Added unit tests to cover new or updated functionality.

Make sure to check off this list before asking for review.

[codecov]

Codecov Report

Patch coverage: 64.70% and project coverage change: +0.01 🎉

Comparison is base (c236d5d) 17.53% compared to head (9bd0a03) 17.54%.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #5920      +/-   ##
==========================================
+ Coverage   17.53%   17.54%   +0.01%     
==========================================
  Files        2500     2500              
  Lines      114336   114365      +29     
  Branches    17849    17859      +10     
==========================================
+ Hits        20050    20069      +19     
- Misses      93694    93704      +10     
  Partials      592      592              

Impacted Files	Coverage Δ
packages/core/src/NodeExecuteFunctions.ts	10.56% <0.00%> (-0.10%)	⬇️
packages/core/src/WorkflowExecutionMetadata.ts	85.71% <91.66%> (+7.14%)	⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

[github-actions]

✅ All Cypress E2E specs passed

[krynble]

I think we should also accept numbers. It's become very annoying, if I have a number that is generated I simply can't save it as is.

[krynble]

You can use this workflow as an example to see the error.

{
  "meta": {
    "instanceId": "27cc9b56542ad45b38725555722c50a1c3fee1670bbb67980558314ee08517c4"
  },
  "nodes": [
    {
      "parameters": {
        "path": "a59cd802-3f21-4672-a208-c5bbb45711f6",
        "responseMode": "lastNode",
        "options": {}
      },
      "id": "5d434c5e-7794-46da-acee-1cee883c2d6e",
      "name": "Webhook",
      "type": "n8n-nodes-base.webhook",
      "typeVersion": 1,
      "position": [
        780,
        540
      ],
      "webhookId": "a59cd802-3f21-4672-a208-c5bbb45711f6"
    },
    {
      "parameters": {
        "jsCode": "// Loop over input items and add a new field\n// called 'myNewField' to the JSON of each one\n\nconst generatedNumber = Math.floor(Math.random() * 5);\n\nconst large = Math.floor(Math.random() * 1000);\n\n\n$execution.customData.set(`potato${generatedNumber}`, generatedNumber);\n$execution.customData.set(`name${generatedNumber}`, generatedNumber);\n\n\n$execution.customData.set(`large${large}`, '0');\n\nfor (const item of $input.all()) {\n  item.json.generatedNumber = generatedNumber;\n}\n\nreturn $input.all();"
      },
      "id": "3943cd3f-db65-468c-993a-4543fe340e6f",
      "name": "Code",
      "type": "n8n-nodes-base.code",
      "typeVersion": 1,
      "position": [
        980,
        540
      ]
    },
    {
      "parameters": {
        "keepOnlySet": true,
        "values": {
          "string": [
            {
              "name": "coolStuff",
              "value": "={{ $execution.customData.getAll() }}"
            }
          ]
        },
        "options": {}
      },
      "id": "dee79bb5-b0a8-4916-aa88-2a87f576f579",
      "name": "Set",
      "type": "n8n-nodes-base.set",
      "typeVersion": 1,
      "position": [
        1420,
        540
      ]
    },
    {
      "parameters": {
        "amount": 2,
        "unit": "seconds"
      },
      "id": "f085cf4f-b71b-46fe-96a6-4c201e8db2ab",
      "name": "Wait",
      "type": "n8n-nodes-base.wait",
      "typeVersion": 1,
      "position": [
        1200,
        540
      ],
      "webhookId": "c084fefc-6bcc-484d-b0c8-c16188d602f5",
      "disabled": true
    }
  ],
  "connections": {
    "Webhook": {
      "main": [
        [
          {
            "node": "Code",
            "type": "main",
            "index": 0
          }
        ]
      ]
    },
    "Code": {
      "main": [
        [
          {
            "node": "Wait",
            "type": "main",
            "index": 0
          }
        ]
      ]
    },
    "Wait": {
      "main": [
        [
          {
            "node": "Set",
            "type": "main",
            "index": 0
          }
        ]
      ]
    }
  }
}

[krynble]

LGTM!

[github-actions]

✅ All Cypress E2E specs passed

[janober]

Got released with [email protected]