refactor(core): Setup decorator based RBAC (no-changelog) #5787
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Great PR! Please pay attention to the following items before merging: Files matching
Files matching
Make sure to check off this list before asking for review. |
n8n-assistant
bot
added
core
netroy
force-pushed
the
controller-decorators-part2
branch
from
ab3baf9 to
c3e053f
Compare
netroy
force-pushed
the
controller-decorators-part2
branch
from
c3e053f to
22b556c
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #5787 +/- ##
==========================================
- Coverage 18.67% 18.67% -0.01%
==========================================
Files 2582 2582
Lines 116479 116461 -18
Branches 18178 18177 -1
==========================================
- Hits 21751 21747 -4
+ Misses 94090 94080 -10
+ Partials 638 634 -4
... and 1 file with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
netroy
force-pushed
the
controller-decorators-part2
branch
from
22b556c to
a317e88
Compare
krynble
suggested changes
Apr 14, 2023
Contributor
krynble
left a comment
krynble
left a comment
There was a problem hiding this comment.
Did some manual testing and could only find this issue but it was blocking the very first screen after logging in.
Contributor
|
✅ All Cypress E2E specs passed |
netroy
force-pushed
the
controller-decorators-part2
branch
from
a317e88 to
a5d395f
Compare
Contributor
|
✅ All Cypress E2E specs passed |
netroy
force-pushed
the
controller-decorators-part2
branch
from
a5d395f to
1575857
Compare
krynble
approved these changes
Apr 24, 2023
Contributor
krynble
left a comment
krynble
left a comment
There was a problem hiding this comment.
Ran some more tests and could not find any issues. LGTM.
Contributor
|
✅ All Cypress E2E specs passed |
MiloradFilipovic
added a commit
that referenced
this pull request
Apr 24, 2023
* master: refactor: Async functions don't need to explicitly return promises (no-changelog) (#6041) SSO/SAML : add Base URL to redirects in acsHandler (#5923) refactor: Integrate `consistent-type-imports` in FE packages (no-changelog) (#6060) fix(core): Skip license activation when instance was already activated (#6064) refactor(core): Setup decorator based RBAC (no-changelog) (#5787) # Conflicts: # packages/editor-ui/src/mixins/restApi.ts
MiloradFilipovic
added a commit
that referenced
this pull request
Apr 24, 2023
* master: refactor(editor): Delete leftover restApi mixin file (no-changelog) (#6074) docs: Remove version notice from overhauled nodes (no-changelog) (#6071) refactor(editor): Combine type imports in `editor-ui` (no-changelog) (#6072) refactor: Async functions don't need to explicitly return promises (no-changelog) (#6041) SSO/SAML : add Base URL to redirects in acsHandler (#5923) refactor: Integrate `consistent-type-imports` in FE packages (no-changelog) (#6060) fix(core): Skip license activation when instance was already activated (#6064) refactor(core): Setup decorator based RBAC (no-changelog) (#5787) test: Add run linking tests (#6061) # Conflicts: # packages/editor-ui/src/components/ParameterInputWrapper.vue
sunilrr
pushed a commit
to fl-g6/qp-n8n
that referenced
this pull request
Apr 24, 2023
Member
|
Got released with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.