Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cli): use absolute paths for loading custom nodes and credentials #4099

Merged
merged 1 commit into from
Sep 14, 2022

Conversation

netroy
Copy link
Member

@netroy netroy commented Sep 14, 2022

custom-node loading broke because of this change, as we started using relative paths for the files returned by glob #4082

Copy link
Contributor

@krynble krynble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@n8n-assistant n8n-assistant bot added core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team labels Sep 14, 2022
@netroy netroy merged commit 43c9f01 into master Sep 14, 2022
@netroy netroy deleted the fix-custom-node-loading branch September 14, 2022 08:37
@n8n-assistant n8n-assistant bot added the Upcoming Release Will be part of the upcoming release label Sep 14, 2022
@janober
Copy link
Member

janober commented Sep 15, 2022

Got released with [email protected]

@janober janober removed the Upcoming Release Will be part of the upcoming release label Sep 15, 2022
valya pushed a commit to valya/n8n that referenced this pull request Nov 8, 2022
…n8n-io#4099)

custom-node loading broke because of this change, as we started using relative paths for the files returned by `glob` n8n-io#4082
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants