-
Notifications
You must be signed in to change notification settings - Fork 7.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(design-system): merge n8n square button into n8n button #4075
Merged
cstuncsik
merged 12 commits into
master
from
n8n-4254-merge-n8n-square-button-into-n8n-button
Sep 15, 2022
Merged
refactor(design-system): merge n8n square button into n8n button #4075
cstuncsik
merged 12 commits into
master
from
n8n-4254-merge-n8n-square-button-into-n8n-button
Sep 15, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cstuncsik
changed the title
reafctor(design-system): merge n8n square button into n8n button
refactor(design-system): merge n8n square button into n8n button
Sep 12, 2022
mutdmour
reviewed
Sep 12, 2022
cstuncsik
force-pushed
the
n8n-4254-merge-n8n-square-button-into-n8n-button
branch
from
September 12, 2022 19:37
3f672db
to
ef45d19
Compare
mutdmour
reviewed
Sep 14, 2022
@@ -427,6 +432,7 @@ $loading-overlay-background-color: rgba(255, 255, 255, 0); | |||
|
|||
.icon { | |||
display: inline-flex; | |||
justify-content: center; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nitpick - spacing
cstuncsik
force-pushed
the
n8n-4254-merge-n8n-square-button-into-n8n-button
branch
from
September 14, 2022 11:41
bdc6399
to
80b4d0a
Compare
mutdmour
approved these changes
Sep 15, 2022
cstuncsik
deleted the
n8n-4254-merge-n8n-square-button-into-n8n-button
branch
September 15, 2022 09:41
n8n-assistant
bot
added
the
Upcoming Release
Will be part of the upcoming release
label
Sep 15, 2022
Got released with |
valya
pushed a commit
to valya/n8n
that referenced
this pull request
Nov 8, 2022
…-io#4075) * feat(design-system): button as square shape * refactor(editor-ui): drop n8n-square-button in favor of n8n-button * refactor(design-system): remove obsolete n8n-square-button * fix(design-system): icon only square button icon position * fix(design-system): icon only square button icon position * chore(design-system): update button test snapshot * fix(design-system): overriding default square button styles * fix(editor-ui): using tertiary button variant in survey without local style overrides * refactor(design-system): simplifying and partially merging icon-button and button * fix(design-system): remove unused prop from icon-button * fix(design-system): square button should have the old dimensions * fix(design-system): square button update test snapshots
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.