Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(design-system): merge n8n square button into n8n button #4075

Merged
merged 12 commits into from
Sep 15, 2022

Conversation

cstuncsik
Copy link
Contributor

No description provided.

@cstuncsik cstuncsik added ui Enhancement in /editor-ui or /design-system tech debt labels Sep 12, 2022
@cstuncsik cstuncsik changed the title reafctor(design-system): merge n8n square button into n8n button refactor(design-system): merge n8n square button into n8n button Sep 12, 2022
@n8n-assistant n8n-assistant bot added the n8n team Authored by the n8n team label Sep 12, 2022
@cstuncsik cstuncsik force-pushed the n8n-4254-merge-n8n-square-button-into-n8n-button branch from 3f672db to ef45d19 Compare September 12, 2022 19:37
@@ -427,6 +432,7 @@ $loading-overlay-background-color: rgba(255, 255, 255, 0);

.icon {
display: inline-flex;
justify-content: center;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nitpick - spacing

@cstuncsik cstuncsik force-pushed the n8n-4254-merge-n8n-square-button-into-n8n-button branch from bdc6399 to 80b4d0a Compare September 14, 2022 11:41
@cstuncsik cstuncsik merged commit ec2c552 into master Sep 15, 2022
@cstuncsik cstuncsik deleted the n8n-4254-merge-n8n-square-button-into-n8n-button branch September 15, 2022 09:41
@n8n-assistant n8n-assistant bot added the Upcoming Release Will be part of the upcoming release label Sep 15, 2022
@janober
Copy link
Member

janober commented Sep 15, 2022

Got released with [email protected]

valya pushed a commit to valya/n8n that referenced this pull request Nov 8, 2022
…-io#4075)

* feat(design-system): button as square shape

* refactor(editor-ui): drop n8n-square-button in favor of n8n-button

* refactor(design-system): remove obsolete n8n-square-button

* fix(design-system): icon only square button icon position

* fix(design-system): icon only square button icon position

* chore(design-system): update button test snapshot

* fix(design-system): overriding default square button styles

* fix(editor-ui): using tertiary button variant in survey without local style overrides

* refactor(design-system): simplifying and partially merging icon-button and button

* fix(design-system): remove unused prop from icon-button

* fix(design-system): square button should have the old dimensions

* fix(design-system): square button update test snapshots
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
n8n team Authored by the n8n team tech debt ui Enhancement in /editor-ui or /design-system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants