Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(nodes-base): Apply lint rule node-param-operation-option-description-wrong-for-get-many #4064

Merged
merged 8 commits into from
Sep 13, 2022
Merged

refactor(nodes-base): Apply lint rule node-param-operation-option-description-wrong-for-get-many #4064

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
1d8361f
:shirt: Enable rule
ivov Sep 9, 2022
6ac8f53
:arrow_up: Upgrade linter
ivov Sep 9, 2022
d81feb5
:package: Update `package-lock.json`
ivov Sep 9, 2022
a91cd24
:shirt: Apply rule
ivov Sep 9, 2022
b386e0a
:pencil2: Fix plurals
ivov Sep 12, 2022
5ab5140
:pencil2: More typos
ivov Sep 12, 2022
d621c6f
:pencil2: Final typos
ivov Sep 13, 2022
de93ed9
:twisted_rightwards_arrows: Merge master
ivov Sep 13, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
1 change: 1 addition & 0 deletions packages/nodes-base/.eslintrc.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,6 +147,7 @@ module.exports = {
'n8n-nodes-base/node-param-min-value-wrong-for-limit': 'error',
'n8n-nodes-base/node-param-multi-options-type-unsorted-items': 'error',
'n8n-nodes-base/node-param-operation-option-action-wrong-for-get-many': 'error',
'n8n-nodes-base/node-param-operation-option-description-wrong-for-get-many': 'error',
'n8n-nodes-base/node-param-operation-option-without-action': 'error',
'n8n-nodes-base/node-param-operation-without-no-data-expression': 'error',
'n8n-nodes-base/node-param-option-description-identical-to-name': 'error',
Expand Down
2 changes: 1 addition & 1 deletion packages/nodes-base/nodes/ActiveCampaign/AccountDescription.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ export const accountOperations: INodeProperties[] = [
{
name: 'Get Many',
value: 'getAll',
description: 'Get data of all accounts',
description: 'Get data of many accounts',
action: 'Get many accounts',
},
{
Expand Down
2 changes: 1 addition & 1 deletion packages/nodes-base/nodes/ActiveCampaign/ConnectionDescription.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ export const connectionOperations: INodeProperties[] = [
{
name: 'Get Many',
value: 'getAll',
description: 'Get data of all connections',
description: 'Get data of many connections',
action: 'Get many connections',
},
{
Expand Down
2 changes: 1 addition & 1 deletion packages/nodes-base/nodes/ActiveCampaign/ContactDescription.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ export const contactOperations: INodeProperties[] = [
{
name: 'Get Many',
value: 'getAll',
description: 'Get data of all contact',
description: 'Get data of many contacts',
action: 'Get many contacts',
},
{
Expand Down
2 changes: 1 addition & 1 deletion packages/nodes-base/nodes/ActiveCampaign/DealDescription.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ export const dealOperations: INodeProperties[] = [
{
name: 'Get Many',
value: 'getAll',
description: 'Get data of all deals',
description: 'Get data of many deals',
action: 'Get many deals',
},
{
Expand Down
2 changes: 1 addition & 1 deletion packages/nodes-base/nodes/ActiveCampaign/EcomCustomerDescription.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ export const ecomCustomerOperations: INodeProperties[] = [
{
name: 'Get Many',
value: 'getAll',
description: 'Get data of all E-commerce Customer',
description: 'Get data of many E-commerce Customers',
action: 'Get many e-commerce customers',
},
{
Expand Down
2 changes: 1 addition & 1 deletion packages/nodes-base/nodes/ActiveCampaign/EcomOrderDescription.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ export const ecomOrderOperations: INodeProperties[] = [
{
name: 'Get Many',
value: 'getAll',
description: 'Get data of all orders',
description: 'Get data of many orders',
action: 'Get many e-commerce orders',
},
{
Expand Down
2 changes: 1 addition & 1 deletion packages/nodes-base/nodes/ActiveCampaign/EcomOrderProductsDescription.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ export const ecomOrderProductsOperations: INodeProperties[] = [
{
name: 'Get Many',
value: 'getAll',
description: 'Get data of all order products',
description: 'Get data of many order products',
action: 'Get many ecommerce orders',
},
{
Expand Down
2 changes: 1 addition & 1 deletion packages/nodes-base/nodes/ActiveCampaign/ListDescription.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ export const listOperations: INodeProperties[] = [
{
name: 'Get Many',
value: 'getAll',
description: 'Get all lists',
description: 'Get many lists',
action: 'Get many lists',
},
],
Expand Down
2 changes: 1 addition & 1 deletion packages/nodes-base/nodes/ActiveCampaign/TagDescription.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ export const tagOperations: INodeProperties[] = [
{
name: 'Get Many',
value: 'getAll',
description: 'Get data of all tags',
description: 'Get data of many tags',
action: 'Get many tags',
},
{
Expand Down
2 changes: 1 addition & 1 deletion packages/nodes-base/nodes/Affinity/ListDescription.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ export const listOperations: INodeProperties[] = [
{
name: 'Get Many',
value: 'getAll',
description: 'Get all lists',
description: 'Get many lists',
action: 'Get many lists',
},
],
Expand Down
2 changes: 1 addition & 1 deletion packages/nodes-base/nodes/Affinity/ListEntryDescription.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ export const listEntryOperations: INodeProperties[] = [
{
name: 'Get Many',
value: 'getAll',
description: 'Get all list entries',
description: 'Get many list entries',
action: 'Get many list entries',
},
],
Expand Down
2 changes: 1 addition & 1 deletion packages/nodes-base/nodes/Affinity/OrganizationDescription.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ export const organizationOperations: INodeProperties[] = [
{
name: 'Get Many',
value: 'getAll',
description: 'Get all organizations',
description: 'Get many organizations',
action: 'Get many organizations',
},
{
Expand Down
2 changes: 1 addition & 1 deletion packages/nodes-base/nodes/Affinity/PersonDescription.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ export const personOperations: INodeProperties[] = [
{
name: 'Get Many',
value: 'getAll',
description: 'Get all persons',
description: 'Get many persons',
action: 'Get many people',
},
{
Expand Down
2 changes: 1 addition & 1 deletion packages/nodes-base/nodes/AgileCrm/CompanyDescription.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ export const companyOperations: INodeProperties[] = [
{
name: 'Get Many',
value: 'getAll',
description: 'Get all companies',
description: 'Get many companies',
action: 'Get many companies',
},
{
Expand Down
2 changes: 1 addition & 1 deletion packages/nodes-base/nodes/AgileCrm/ContactDescription.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ export const contactOperations: INodeProperties[] = [
{
name: 'Get Many',
value: 'getAll',
description: 'Get all contacts',
description: 'Get many contacts',
action: 'Get many contacts',
},
{
Expand Down
2 changes: 1 addition & 1 deletion packages/nodes-base/nodes/AgileCrm/DealDescription.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ export const dealOperations: INodeProperties[] = [
{
name: 'Get Many',
value: 'getAll',
description: 'Get all deals',
description: 'Get many deals',
action: 'Get many deals',
},
{
Expand Down
8 changes: 4 additions & 4 deletions packages/nodes-base/nodes/Asana/Asana.node.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,7 +145,7 @@ export class Asana implements INodeType {
{
name: 'Get Many',
value: 'getAll',
description: 'Get all substasks',
description: 'Get many substasks',
action: 'Get many subtasks',
},
],
Expand Down Expand Up @@ -393,7 +393,7 @@ export class Asana implements INodeType {
{
name: 'Get Many',
value: 'getAll',
description: 'Get all tasks',
description: 'Get many tasks',
action: 'Get many tasks',
},
{
Expand Down Expand Up @@ -1272,7 +1272,7 @@ export class Asana implements INodeType {
{
name: 'Get Many',
value: 'getAll',
description: 'Get all users',
description: 'Get many users',
action: 'Get many users',
},
],
Expand Down Expand Up @@ -1357,7 +1357,7 @@ export class Asana implements INodeType {
{
name: 'Get Many',
value: 'getAll',
description: 'Get all projects',
description: 'Get many projects',
action: 'Get many projects',
},
{
Expand Down
2 changes: 1 addition & 1 deletion packages/nodes-base/nodes/Automizy/ContactDescription.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ export const contactOperations: INodeProperties[] = [
{
name: 'Get Many',
value: 'getAll',
description: 'Get all contacts',
description: 'Get many contacts',
action: 'Get many contacts',
},
{
Expand Down
2 changes: 1 addition & 1 deletion packages/nodes-base/nodes/Automizy/ListDescription.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ export const listOperations: INodeProperties[] = [
{
name: 'Get Many',
value: 'getAll',
description: 'Get all lists',
description: 'Get many lists',
action: 'Get many lists',
},
{
Expand Down
2 changes: 1 addition & 1 deletion packages/nodes-base/nodes/Autopilot/ContactDescription.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ export const contactOperations: INodeProperties[] = [
{
name: 'Get Many',
value: 'getAll',
description: 'Get all contacts',
description: 'Get many contacts',
action: 'Get many contacts',
},
],
Expand Down
2 changes: 1 addition & 1 deletion packages/nodes-base/nodes/Autopilot/ContactListDescription.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ export const contactListOperations: INodeProperties[] = [
{
name: 'Get Many',
value: 'getAll',
description: 'Get all contacts on list',
description: 'Get many contacts from a list',
action: 'Get many contact lists',
},
{
Expand Down
2 changes: 1 addition & 1 deletion packages/nodes-base/nodes/Autopilot/ListDescription.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ export const listOperations: INodeProperties[] = [
{
name: 'Get Many',
value: 'getAll',
description: 'Get all lists',
description: 'Get many lists',
action: 'Get many lists',
},
],
Expand Down
2 changes: 1 addition & 1 deletion packages/nodes-base/nodes/Aws/DynamoDB/ItemDescription.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ export const itemOperations: INodeProperties[] = [
{
name: 'Get Many',
value: 'getAll',
description: 'Get all items',
description: 'Get many items',
action: 'Get many items',
},
],
Expand Down
2 changes: 1 addition & 1 deletion packages/nodes-base/nodes/Aws/S3/BucketDescription.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ export const bucketOperations: INodeProperties[] = [
{
name: 'Get Many',
value: 'getAll',
description: 'Get all buckets',
description: 'Get many buckets',
action: 'Get many buckets',
},
{
Expand Down
2 changes: 1 addition & 1 deletion packages/nodes-base/nodes/Aws/S3/FileDescription.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ export const fileOperations: INodeProperties[] = [
{
name: 'Get Many',
value: 'getAll',
description: 'Get all files',
description: 'Get many files',
action: 'Get many files',
},
{
Expand Down
2 changes: 1 addition & 1 deletion packages/nodes-base/nodes/Aws/S3/FolderDescription.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ export const folderOperations: INodeProperties[] = [
{
name: 'Get Many',
value: 'getAll',
description: 'Get all folders',
description: 'Get many folders',
action: 'Get many folders',
},
],
Expand Down
4 changes: 2 additions & 2 deletions packages/nodes-base/nodes/Aws/SES/AwsSes.node.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,7 @@ export class AwsSes implements INodeType {
name: 'Get Many',
value: 'getAll',
description:
'Get all the existing custom verification email templates for your account',
'Get many of the existing custom verification email templates for your account',
action: 'Get many custom verifications',
},
{
Expand Down Expand Up @@ -649,7 +649,7 @@ export class AwsSes implements INodeType {
{
name: 'Get Many',
value: 'getAll',
description: 'Get all templates',
description: 'Get many templates',
action: 'Get many templates',
},
{
Expand Down
2 changes: 1 addition & 1 deletion packages/nodes-base/nodes/Aws/Transcribe/AwsTranscribe.node.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ export class AwsTranscribe implements INodeType {
{
name: 'Get Many',
value: 'getAll',
description: 'Get all transcription jobs',
description: 'Get many transcription jobs',
action: 'Get many transcription jobs',
},
],
Expand Down
2 changes: 1 addition & 1 deletion packages/nodes-base/nodes/BambooHr/v1/actions/employee/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ export const descriptions: INodeProperties[] = [
{
name: 'Get Many',
value: 'getAll',
description: 'Get all employees',
description: 'Get many employees',
action: 'Get many employees',
},
{
Expand Down
2 changes: 1 addition & 1 deletion packages/nodes-base/nodes/BambooHr/v1/actions/employeeDocument/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ export const descriptions: INodeProperties[] = [
{
name: 'Get Many',
value: 'getAll',
description: 'Get all employee document',
description: 'Get many employee documents',
action: 'Get many employee documents',
},
{
Expand Down
2 changes: 1 addition & 1 deletion packages/nodes-base/nodes/BambooHr/v1/actions/file/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ export const descriptions: INodeProperties[] = [
{
name: 'Get Many',
value: 'getAll',
description: 'Get all company files',
description: 'Get many company files',
action: 'Get many files',
},
{
Expand Down
2 changes: 1 addition & 1 deletion packages/nodes-base/nodes/Bannerbear/TemplateDescription.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ export const templateOperations: INodeProperties[] = [
{
name: 'Get Many',
value: 'getAll',
description: 'Get all templates',
description: 'Get many templates',
action: 'Get many templates',
},
],
Expand Down
2 changes: 1 addition & 1 deletion packages/nodes-base/nodes/Baserow/Baserow.node.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,7 @@ export class Baserow implements INodeType {
{
name: 'Get Many',
value: 'getAll',
description: 'Retrieve all rows',
description: 'Retrieve many rows',
action: 'Get many rows',
},
{
Expand Down
2 changes: 1 addition & 1 deletion packages/nodes-base/nodes/Beeminder/Beeminder.node.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ export class Beeminder implements INodeType {
{
name: 'Get Many',
value: 'getAll',
description: 'Get all datapoints for a goal',
description: 'Get many datapoints for a goal',
action: 'Get many datapoints for a goal',
},
{
Expand Down
2 changes: 1 addition & 1 deletion packages/nodes-base/nodes/CircleCi/PipelineDescription.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ export const pipelineOperations: INodeProperties[] = [
{
name: 'Get Many',
value: 'getAll',
description: 'Get all pipelines',
description: 'Get many pipelines',
action: 'Get many pipelines',
},
{
Expand Down
2 changes: 1 addition & 1 deletion packages/nodes-base/nodes/ClickUp/CommentDescription.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ export const commentOperations: INodeProperties[] = [
{
name: 'Get Many',
value: 'getAll',
description: 'Get all comments',
description: 'Get many comments',
action: 'Get many comments',
},
{
Expand Down
2 changes: 1 addition & 1 deletion packages/nodes-base/nodes/ClickUp/FolderDescription.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ export const folderOperations: INodeProperties[] = [
{
name: 'Get Many',
value: 'getAll',
description: 'Get all folders',
description: 'Get many folders',
action: 'Get many folders',
},
{
Expand Down
2 changes: 1 addition & 1 deletion packages/nodes-base/nodes/ClickUp/GoalDescription.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ export const goalOperations: INodeProperties[] = [
{
name: 'Get Many',
value: 'getAll',
description: 'Get all goals',
description: 'Get many goals',
action: 'Get many goals',
},
{
Expand Down
2 changes: 1 addition & 1 deletion packages/nodes-base/nodes/ClickUp/ListDescription.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ export const listOperations: INodeProperties[] = [
{
name: 'Get Many',
value: 'getAll',
description: 'Get all lists',
description: 'Get many lists',
action: 'Get many lists',
},
{
Expand Down
Loading