Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(nodes-base): Apply lint rule node-param-operation-option-description-wrong-for-get-many #4064

Merged
merged 8 commits into from
Sep 13, 2022
Merged

refactor(nodes-base): Apply lint rule node-param-operation-option-description-wrong-for-get-many #4064

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
1d8361f
:shirt: Enable rule
ivov Sep 9, 2022
6ac8f53
:arrow_up: Upgrade linter
ivov Sep 9, 2022
d81feb5
:package: Update `package-lock.json`
ivov Sep 9, 2022
a91cd24
:shirt: Apply rule
ivov Sep 9, 2022
b386e0a
:pencil2: Fix plurals
ivov Sep 12, 2022
5ab5140
:pencil2: More typos
ivov Sep 12, 2022
d621c6f
:pencil2: Final typos
ivov Sep 13, 2022
de93ed9
:twisted_rightwards_arrows: Merge master
ivov Sep 13, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
1 change: 1 addition & 0 deletions .eslintrc.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -457,6 +457,7 @@ module.exports = {
'n8n-nodes-base/node-param-multi-options-type-unsorted-items': 'error',
'n8n-nodes-base/node-param-operation-without-no-data-expression': 'error',
'n8n-nodes-base/node-param-operation-option-action-wrong-for-get-many': 'error',
'n8n-nodes-base/node-param-operation-option-description-wrong-for-get-many': 'error',
'n8n-nodes-base/node-param-operation-option-without-action': 'error',
'n8n-nodes-base/node-param-option-description-identical-to-name': 'error',
'n8n-nodes-base/node-param-option-name-containing-star': 'error',
Expand Down
194 changes: 10 additions & 184 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion packages/nodes-base/nodes/ActiveCampaign/AccountDescription.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ export const accountOperations: INodeProperties[] = [
{
name: 'Get Many',
value: 'getAll',
description: 'Get data of all accounts',
description: 'Get data of many accounts',
action: 'Get many accounts',
},
{
Expand Down
2 changes: 1 addition & 1 deletion packages/nodes-base/nodes/ActiveCampaign/ConnectionDescription.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ export const connectionOperations: INodeProperties[] = [
{
name: 'Get Many',
value: 'getAll',
description: 'Get data of all connections',
description: 'Get data of many connections',
action: 'Get many connections',
},
{
Expand Down
2 changes: 1 addition & 1 deletion packages/nodes-base/nodes/ActiveCampaign/ContactDescription.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ export const contactOperations: INodeProperties[] = [
{
name: 'Get Many',
value: 'getAll',
description: 'Get data of all contact',
description: 'Get data of many contact',
ivov marked this conversation as resolved.
Show resolved Hide resolved
action: 'Get many contacts',
},
{
Expand Down
2 changes: 1 addition & 1 deletion packages/nodes-base/nodes/ActiveCampaign/DealDescription.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ export const dealOperations: INodeProperties[] = [
{
name: 'Get Many',
value: 'getAll',
description: 'Get data of all deals',
description: 'Get data of many deals',
action: 'Get many deals',
},
{
Expand Down
2 changes: 1 addition & 1 deletion packages/nodes-base/nodes/ActiveCampaign/EcomCustomerDescription.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ export const ecomCustomerOperations: INodeProperties[] = [
{
name: 'Get Many',
value: 'getAll',
description: 'Get data of all E-commerce Customer',
description: 'Get data of many E-commerce Customer',
ivov marked this conversation as resolved.
Show resolved Hide resolved
action: 'Get many e-commerce customers',
},
{
Expand Down
2 changes: 1 addition & 1 deletion packages/nodes-base/nodes/ActiveCampaign/EcomOrderDescription.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ export const ecomOrderOperations: INodeProperties[] = [
{
name: 'Get Many',
value: 'getAll',
description: 'Get data of all orders',
description: 'Get data of many orders',
action: 'Get many e-commerce orders',
},
{
Expand Down
2 changes: 1 addition & 1 deletion packages/nodes-base/nodes/ActiveCampaign/EcomOrderProductsDescription.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ export const ecomOrderProductsOperations: INodeProperties[] = [
{
name: 'Get Many',
value: 'getAll',
description: 'Get data of all order products',
description: 'Get data of many order products',
action: 'Get many ecommerce orders',
},
{
Expand Down
2 changes: 1 addition & 1 deletion packages/nodes-base/nodes/ActiveCampaign/ListDescription.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ export const listOperations: INodeProperties[] = [
{
name: 'Get Many',
value: 'getAll',
description: 'Get all lists',
description: 'Get many lists',
action: 'Get many lists',
},
],
Expand Down
2 changes: 1 addition & 1 deletion packages/nodes-base/nodes/ActiveCampaign/TagDescription.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ export const tagOperations: INodeProperties[] = [
{
name: 'Get Many',
value: 'getAll',
description: 'Get data of all tags',
description: 'Get data of many tags',
action: 'Get many tags',
},
{
Expand Down
2 changes: 1 addition & 1 deletion packages/nodes-base/nodes/Affinity/ListDescription.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ export const listOperations: INodeProperties[] = [
{
name: 'Get Many',
value: 'getAll',
description: 'Get all lists',
description: 'Get many lists',
action: 'Get many lists',
},
],
Expand Down
2 changes: 1 addition & 1 deletion packages/nodes-base/nodes/Affinity/ListEntryDescription.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ export const listEntryOperations: INodeProperties[] = [
{
name: 'Get Many',
value: 'getAll',
description: 'Get all list entries',
description: 'Get many list entries',
action: 'Get many list entries',
},
],
Expand Down
Loading