fix(typescript): Use consistent typescript configs - N8N-4552

[netroy]

make all packages inherit tsconfig from the root tsconfig.

Ticket: N8N-4537

[ivov]

Builds fine, runs fine, only minor comments.

1. Let's remove all tsx references? "src/**/*.tsx" "tests/**/*.tsx",, etc.

2. useUnknownInCatchVariables Comment to enable in future?

3. Settings like strictNullChecks, noImplicitAny, etc. are part of strict, which is enabled everywhere except cli. Maybe a comment to remove these settings that are part of strict once we have strict all over?

4. If we only need emitDecoratorMetadata and experimentalDecorators for TypeORM and for your router refactorings in cli, should we set them there only?

5. "outDir": "dist" is repeated in all packages. This is not inheritable?

Ideally if @alexgrozav can check the tsconfig for the FE packages.

[netroy]

Builds fine, runs fine, only minor comments.

1. Let's remove all tsx references? `"src/**/*.tsx"` `"tests/**/*.tsx",`, etc.

Done ✔️

2. `useUnknownInCatchVariables` Comment to enable in future?

enabled it globally, and disabled it on projects that needed it. So now the flag is under a TODO now.

3. Settings like `strictNullChecks`, `noImplicitAny`, etc. are part of `strict`, which is enabled everywhere except cli. Maybe a comment to remove these settings that are part of `strict` once we have `strict` all over?

I tried moving those to the cli tsconfig, but couldn't get it to work. I'll prioritize switching on strict for cli. we can remove these then.

4. If we only need `emitDecoratorMetadata` and `experimentalDecorators` for TypeORM and for your router refactorings in cli, should we set them there only?

Done ✔️

5. `"outDir": "dist"` is repeated in all packages. This is not inheritable?

unfortunately not.
From what I understand, outDir is relative to the tsconfig defining it.

[ivov]

Rebuilt, retested, all good.

6. Do we need to build the tests? If I remove them from tsconfig, the test command runs fine, maybe ts-jest transpiles them on the fly.

7. When saving the tsconfigs locally, they are getting autoformatted with Prettier. If you can please format them and set up the extension dangmai.workspace-default-settings so your editor uses .vscode/settings.default.json to do this automatically in future.

Let's wait for Alex but otherwise LGTM. Thanks for cleaning this up.

[netroy]

Rebuilt, retested, all good.

6. Do we need to build the tests? If I remove them from tsconfig, the test command runs fine, maybe ts-jest transpiles them on the fly.

exactly, ts-jest transpiles the tests. we don't need to compile them.

7. When saving the tsconfigs locally, they are getting autoformatted with Prettier. If you can please format them and set up the extension `dangmai.workspace-default-settings` so your editor uses `.vscode/settings.default.json` to do this automatically in future.

I'll send another PR where I enable prettier & prettier-eslint on everything. Will reformat all JSON files in there as well.

Let's wait for Alex but otherwise LGTM. Thanks for cleaning this up.

[ivov]

we don't need to compile them.

Perfect, let's remove them all then from tsconfigs, to reduce build time and published package size.

[netroy]

we don't need to compile them.

Perfect, let's remove them all then from tsconfigs, to reduce build time and published package size.

done. also, ran prettier on all the tsconfigs.

[ivov]

🚀

[janober]

Got released with [email protected]