Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix node versioning in client #3819

Merged
merged 10 commits into from
Aug 3, 2022
Merged

Fix node versioning in client #3819

merged 10 commits into from
Aug 3, 2022

Conversation

ivov
Copy link
Contributor

@ivov ivov commented Aug 2, 2022

No description provided.

@n8n-assistant n8n-assistant bot added n8n team Authored by the n8n team ui Enhancement in /editor-ui or /design-system labels Aug 2, 2022
mutdmour
mutdmour reviewed Aug 3, 2022
View reviewed changes
Copy link
Contributor

@mutdmour mutdmour left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.. just a couple of comments to clean up/refactor. will test now

packages/editor-ui/src/modules/nodeTypes.ts Outdated Show resolved Hide resolved
packages/editor-ui/src/components/NodeCreator/NodeCreator.vue Outdated Show resolved Hide resolved
@janober janober merged commit 6e1aaa1 into master Aug 3, 2022
@janober janober deleted the n8n-4270-node-versioning-bug branch August 3, 2022 11:11
@janober
Copy link
Member

janober commented Aug 3, 2022

Thanks a lot. Got merged.

@janober janober added the Upcoming Release Will be part of the upcoming release label Aug 3, 2022
@janober
Copy link
Member

janober commented Aug 3, 2022

Got released with [email protected]

@janober janober removed the Upcoming Release Will be part of the upcoming release label Aug 3, 2022
brianinoa pushed a commit that referenced this pull request Aug 5, 2022
@ivov
refactor: Fix node versioning again (#3819)
6cdad8f 
* 📘 Update state interface

* ⚡ Adjust store module to interface

* 🔥 Remove excess check

* 🐛 Fix filtering

* 🐛 Ensure default to latest version

* ✨ Add `allLatestNodeTypes` getter

* 🔥 Remove excess checks

* ⚡ Simplify expression

* ⚡ Add check

* 🐛 Account for unknown node type name
brianinoa pushed a commit that referenced this pull request Aug 5, 2022
@ivov
refactor: Fix node versioning again (#3819)
209fae8 
* 📘 Update state interface

* ⚡ Adjust store module to interface

* 🔥 Remove excess check

* 🐛 Fix filtering

* 🐛 Ensure default to latest version

* ✨ Add `allLatestNodeTypes` getter

* 🔥 Remove excess checks

* ⚡ Simplify expression

* ⚡ Add check

* 🐛 Account for unknown node type name
@saurabharch saurabharch mentioned this pull request Feb 11, 2024
Closed
@reconsumeralization reconsumeralization mentioned this pull request Feb 11, 2024
Open
@johnperez416 johnperez416 mentioned this pull request Feb 11, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mutdmour mutdmour mutdmour approved these changes

Assignees
No one assigned
Labels
n8n team Authored by the n8n team ui Enhancement in /editor-ui or /design-system
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ivov @janober @mutdmour