Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correct misfix from node-param-display-name-wrong-for-dynamic-multi-options #3575

Merged
merged 2 commits into from
Jun 23, 2022
Merged

Correct misfix from node-param-display-name-wrong-for-dynamic-multi-options #3575

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b9cc07d
:shirt: Correct misfix
ivov Jun 22, 2022
0f63b5e
:shirt: Fix build
ivov Jun 22, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/cli/src/Logger.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
/* eslint-disable @typescript-eslint/no-unsafe-return */
/* eslint-disable @typescript-eslint/no-shadow */
/* eslint-disable @typescript-eslint/no-unsafe-assignment */
import winston from 'winston';
Expand Down
3 changes: 2 additions & 1 deletion packages/nodes-base/nodes/Automizy/ContactDescription.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -431,7 +431,8 @@ export const contactFields: INodeProperties[] = [
],
},
{
displayName: 'Remove Tag Names or IDs',
// eslint-disable-next-line n8n-nodes-base/node-param-display-name-wrong-for-dynamic-multi-options
displayName: 'Remove Tags',
name: 'removeTags',
type: 'multiOptions',
typeOptions: {
Expand Down
4 changes: 2 additions & 2 deletions packages/nodes-base/nodes/CoinGecko/CoinDescription.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -182,7 +182,7 @@ export const coinFields: INodeProperties[] = [
placeholder: 'bitcoin',
},
{
displayName: 'Base Currencies Name or ID',
displayName: 'Base Currency Names or IDs',
name: 'baseCurrencies',
required: true,
type: 'multiOptions',
Expand Down Expand Up @@ -330,7 +330,7 @@ export const coinFields: INodeProperties[] = [
description: 'The second currency in the pair. For BTC:ETH this is ETH. Choose from the list, or specify an ID using an <a href="https://docs.n8n.io/nodes/expressions.html#expressions">expression</a>.',
},
{
displayName: 'Quote Currencies Name or ID',
displayName: 'Quote Currency Names or IDs',
name: 'quoteCurrencies',
type: 'multiOptions',
typeOptions: {
Expand Down
12 changes: 8 additions & 4 deletions packages/nodes-base/nodes/Freshservice/descriptions/AgentDescription.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -235,7 +235,8 @@ export const agentFields: INodeProperties[] = [
},
},
{
displayName: 'Member Names or IDs',
// eslint-disable-next-line n8n-nodes-base/node-param-display-name-wrong-for-dynamic-multi-options
displayName: 'Member of Group Names/IDs',
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In this file, I restored the original string since I find it unclear how to apply rule in this case.

name: 'member_of',
type: 'multiOptions',
default: [],
Expand All @@ -251,7 +252,8 @@ export const agentFields: INodeProperties[] = [
default: '',
},
{
displayName: 'Observer Names or IDs',
// eslint-disable-next-line n8n-nodes-base/node-param-display-name-wrong-for-dynamic-multi-options
displayName: 'Observer of Group Names/IDs',
name: 'observer_of',
type: 'multiOptions',
default: [],
Expand Down Expand Up @@ -593,7 +595,8 @@ export const agentFields: INodeProperties[] = [
},
},
{
displayName: 'Member Names or IDs',
// eslint-disable-next-line n8n-nodes-base/node-param-display-name-wrong-for-dynamic-multi-options
displayName: 'Member of Group Names/IDs',
name: 'member_of',
type: 'multiOptions',
default: [],
Expand All @@ -609,7 +612,8 @@ export const agentFields: INodeProperties[] = [
default: '',
},
{
displayName: 'Observer Names or IDs',
// eslint-disable-next-line n8n-nodes-base/node-param-display-name-wrong-for-dynamic-multi-options
displayName: 'Observer of Group Names/IDs',
name: 'observer_of',
type: 'multiOptions',
default: [],
Expand Down
4 changes: 2 additions & 2 deletions packages/nodes-base/nodes/Google/GSuiteAdmin/UserDescription.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -453,7 +453,7 @@ export const userFields: INodeProperties[] = [
},
options: [
{
displayName: 'Custom Schemas Name or ID',
displayName: 'Custom Schema Names or IDs',
name: 'customFieldMask',
type: 'multiOptions',
displayOptions: {
Expand Down Expand Up @@ -587,7 +587,7 @@ export const userFields: INodeProperties[] = [
},
options: [
{
displayName: 'Custom Schemas Name or ID',
displayName: 'Custom Schema Names or IDs',
name: 'customFieldMask',
type: 'multiOptions',
displayOptions: {
Expand Down
5 changes: 3 additions & 2 deletions packages/nodes-base/nodes/Hubspot/DealDescription.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,7 +121,7 @@ export const dealFields: INodeProperties[] = [
default: [],
},
{
displayName: 'Associated Vids Names or IDs',
displayName: 'Associated Vid Names or IDs',
name: 'associatedVids',
type: 'multiOptions',
typeOptions: {
Expand Down Expand Up @@ -456,7 +456,8 @@ export const dealFields: INodeProperties[] = [
description: '<p>Used to include specific deal properties in the results. By default, the results will only include Deal ID and will not include the values for any properties for your Deals.</p><p>Including this parameter will include the data for the specified property in the results. You can include this parameter multiple times to request multiple properties separated by a comma: <code>,</code>.</p>. Choose from the list, or specify IDs using an <a href="https://docs.n8n.io/nodes/expressions.html#expressions">expression</a>.',
},
{
displayName: 'Property Names or IDs',
// eslint-disable-next-line n8n-nodes-base/node-param-display-name-wrong-for-dynamic-multi-options
displayName: 'Properties with History',
name: 'propertiesWithHistory',
type: 'multiOptions',
typeOptions: {
Expand Down