Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nodelinting fourth session #3432

Merged
merged 19 commits into from
Jun 3, 2022
Merged

Nodelinting fourth session #3432

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
5d1015c
:zap: Update `lintfix` script
ivov Jun 2, 2022
2b3a8ee
:shirt: Remove unneeded lint exceptions
ivov Jun 2, 2022
b238d75
:shirt: Run baseline `lintfix`
ivov Jun 3, 2022
c03ab51
:shirt: Apply `node-param-description-miscased-url` (#3441)
ivov Jun 3, 2022
d706e93
:shirt: Apply `rule node-param-placeholder-miscased-id` (#3443)
krynble Jun 3, 2022
5246588
:shirt: Apply `node-param-option-name-wrong-for-upsert` (#3446)
michael-radency Jun 3, 2022
80a2c62
:shirt: Apply `node-param-min-value-wrong-for-limit` (#3442)
agobrech Jun 3, 2022
fbd2dac
Apply `node-param-display-name-wrong-for-dynamic-options` (#3454)
ivov Jun 3, 2022
2cdc0d2
:shirt: Apply `rule node-param-default-wrong-for-number` (#3453)
krynble Jun 3, 2022
2e1e9d9
:shirt: Apply `node-param-default-wrong-for-string` (#3452)
michael-radency Jun 3, 2022
0564ee6
Apply `node-param-display-name-miscased` (#3449)
michael-radency Jun 3, 2022
7c65ad9
:shirt: Apply `node-param-description-lowercase-first-char` (#3451)
michael-radency Jun 3, 2022
a5da210
:shirt: Apply `node-param-description-wrong-for-dynamic-options` (#3456)
agobrech Jun 3, 2022
c96826a
:shirt: Small fix for `node-param-description-wrong-for-dynamic-options`
ivov Jun 3, 2022
5069a9e
:shirt: Apply `node-param-default-wrong-for-fixed-collection` (#3460)
brianinoa Jun 3, 2022
5e59da3
:shirt: Apply `node-param-description-line-break-html-tag` (#3462)
ivov Jun 3, 2022
b5b46ab
:shirt: Run baseline `lintfix`
ivov Jun 3, 2022
978ee78
:shirt: Apply `node-param-options-type-unsorted-items` (#3459)
krynble Jun 3, 2022
d084449
:zap: Restore `lintfix` command
ivov Jun 3, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
13 changes: 13 additions & 0 deletions .eslintrc.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -423,6 +423,19 @@ module.exports = {
'n8n-nodes-base/node-param-resource-with-plural-option': 'error',
'n8n-nodes-base/node-param-resource-without-no-data-expression': 'error',
'n8n-nodes-base/node-param-type-options-missing-from-limit': 'error',
'n8n-nodes-base/node-param-description-wrong-for-dynamic-options': 'error',
'n8n-nodes-base/node-param-display-name-wrong-for-dynamic-options': 'error',
'n8n-nodes-base/node-param-min-value-wrong-for-limit': 'error',
'n8n-nodes-base/node-param-placeholder-miscased-id': 'error',
'n8n-nodes-base/node-param-description-miscased-url': 'error',
'n8n-nodes-base/node-param-option-name-wrong-for-upsert': 'error',
'n8n-nodes-base/node-param-options-type-unsorted-items': 'error',
'n8n-nodes-base/node-param-default-wrong-for-string': 'error',
'n8n-nodes-base/node-param-default-wrong-for-number': 'error',
'n8n-nodes-base/node-param-description-lowercase-first-char': 'error',
'n8n-nodes-base/node-param-display-name-miscased': 'error',
'n8n-nodes-base/node-param-default-wrong-for-fixed-collection': 'error',
'n8n-nodes-base/node-param-description-line-break-html-tag': 'error',
},
},
],
Expand Down
12 changes: 6 additions & 6 deletions packages/nodes-base/nodes/ActionNetwork/descriptions/PersonTagDescription.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,9 +34,9 @@ export const personTagFields: INodeProperties[] = [
// personTag: add
// ----------------------------------------
{
displayName: 'Tag ID',
displayName: 'Tag Name or ID',
name: 'tagId',
description: 'ID of the tag to add',
description: 'ID of the tag to add. Choose from the list, or specify an ID using an <a href="https://docs.n8n.io/nodes/expressions.html#expressions">expression</a>.',
type: 'options',
typeOptions: {
loadOptionsMethod: 'getTags',
Expand Down Expand Up @@ -77,9 +77,9 @@ export const personTagFields: INodeProperties[] = [
// personTag: remove
// ----------------------------------------
{
displayName: 'Tag ID',
displayName: 'Tag Name or ID',
name: 'tagId',
description: 'ID of the tag whose tagging to delete',
description: 'ID of the tag whose tagging to delete. Choose from the list, or specify an ID using an <a href="https://docs.n8n.io/nodes/expressions.html#expressions">expression</a>.',
type: 'options',
typeOptions: {
loadOptionsMethod: 'getTags',
Expand All @@ -98,9 +98,9 @@ export const personTagFields: INodeProperties[] = [
},
},
{
displayName: 'Tagging ID',
displayName: 'Tagging Name or ID',
name: 'taggingId',
description: 'ID of the tagging to remove',
description: 'ID of the tagging to remove. Choose from the list, or specify an ID using an <a href="https://docs.n8n.io/nodes/expressions.html#expressions">expression</a>.',
type: 'options',
typeOptions: {
loadOptionsDependsOn: [
Expand Down
4 changes: 2 additions & 2 deletions packages/nodes-base/nodes/ActiveCampaign/AccountContactDescription.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@ export const accountContactFields: INodeProperties[] = [
default: {},
options: [
{
displayName: 'Job title',
displayName: 'Job Title',
name: 'jobTitle',
type: 'string',
default: '',
Expand Down Expand Up @@ -162,7 +162,7 @@ export const accountContactFields: INodeProperties[] = [
default: {},
options: [
{
displayName: 'Job title',
displayName: 'Job Title',
name: 'jobTitle',
type: 'string',
default: '',
Expand Down
8 changes: 4 additions & 4 deletions packages/nodes-base/nodes/ActiveCampaign/AccountDescription.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,14 +112,14 @@ export const accountFields: INodeProperties[] = [
displayName: 'Field',
values: [
{
displayName: 'Field ID',
displayName: 'Field Name or ID',
name: 'customFieldId',
type: 'options',
typeOptions: {
loadOptionsMethod: 'getAccountCustomFields',
},
default: '',
description: 'ID of the field to set',
description: 'ID of the field to set. Choose from the list, or specify an ID using an <a href="https://docs.n8n.io/nodes/expressions.html#expressions">expression</a>.',
},
{
displayName: 'Field Value',
Expand Down Expand Up @@ -204,14 +204,14 @@ export const accountFields: INodeProperties[] = [
displayName: 'Field',
values: [
{
displayName: 'Field ID',
displayName: 'Field Name or ID',
name: 'customFieldId',
type: 'options',
typeOptions: {
loadOptionsMethod: 'getAccountCustomFields',
},
default: '',
description: 'ID of the field to set',
description: 'ID of the field to set. Choose from the list, or specify an ID using an <a href="https://docs.n8n.io/nodes/expressions.html#expressions">expression</a>.',
},
{
displayName: 'Field Value',
Expand Down
18 changes: 9 additions & 9 deletions packages/nodes-base/nodes/ActiveCampaign/ActiveCampaign.node.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,6 +143,10 @@ export class ActiveCampaign implements INodeType {
name: 'Account Contact',
value: 'accountContact',
},
{
name: 'Connection',
value: 'connection',
},
{
name: 'Contact',
value: 'contact',
Expand All @@ -155,24 +159,20 @@ export class ActiveCampaign implements INodeType {
name: 'Contact Tag',
value: 'contactTag',
},
{
name: 'Connection',
value: 'connection',
},
{
name: 'Deal',
value: 'deal',
},
{
name: 'E-commerce Order',
value: 'ecommerceOrder',
},
{
name: 'E-Commerce Customer',
value: 'ecommerceCustomer',
},
{
name: 'E-commerce Order Product',
name: 'E-Commerce Order',
value: 'ecommerceOrder',
},
{
name: 'E-Commerce Order Product',
value: 'ecommerceOrderProducts',
},
{
Expand Down
4 changes: 2 additions & 2 deletions packages/nodes-base/nodes/ActiveCampaign/ConnectionDescription.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ export const connectionFields: INodeProperties[] = [
description: 'The name of the service',
},
{
displayName: 'External accout ID',
displayName: 'External Account ID',
name: 'externalid',
type: 'string',
default: '',
Expand Down Expand Up @@ -193,7 +193,7 @@ export const connectionFields: INodeProperties[] = [
description: 'The name of the service',
},
{
displayName: 'External accout ID',
displayName: 'External Account ID',
name: 'externalid',
type: 'string',
default: '',
Expand Down
26 changes: 13 additions & 13 deletions packages/nodes-base/nodes/ActiveCampaign/ContactDescription.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@ export const contactFields: INodeProperties[] = [
description: 'The email of the contact to create',
},
{
displayName: 'Update if exists',
displayName: 'Update if Exists',
name: 'updateIfExists',
type: 'boolean',
displayOptions: {
Expand Down Expand Up @@ -122,14 +122,14 @@ export const contactFields: INodeProperties[] = [
displayName: 'Custom Field',
values: [
{
displayName: 'Field ID',
displayName: 'Field Name or ID',
name: 'field',
type: 'options',
typeOptions: {
loadOptionsMethod: 'getContactCustomFields',
},
default: '',
description: 'ID of the field to set',
description: 'ID of the field to set. Choose from the list, or specify an ID using an <a href="https://docs.n8n.io/nodes/expressions.html#expressions">expression</a>.',
},
{
displayName: 'Field Value',
Expand Down Expand Up @@ -221,14 +221,14 @@ export const contactFields: INodeProperties[] = [
displayName: 'Custom Field',
values: [
{
displayName: 'Field ID',
displayName: 'Field Name or ID',
name: 'field',
type: 'options',
typeOptions: {
loadOptionsMethod: 'getContactCustomFields',
},
default: '',
description: 'ID of the field to set',
description: 'ID of the field to set. Choose from the list, or specify an ID using an <a href="https://docs.n8n.io/nodes/expressions.html#expressions">expression</a>.',
},
{
displayName: 'Field Value',
Expand Down Expand Up @@ -405,26 +405,26 @@ export const contactFields: INodeProperties[] = [
name: 'status',
type: 'options',
options: [
{
name: 'Active',
value: 1,
},
{
name: 'Any',
value: -1,
},
{
name: 'Unconfirmed',
value: 0,
name: 'Bounced',
value: 3,
},
{
name: 'Active',
value: 1,
name: 'Unconfirmed',
value: 0,
},
{
name: 'Unsubscribed',
value: 2,
},
{
name: 'Bounced',
value: 3,
},
],
default: '',
},
Expand Down
2 changes: 1 addition & 1 deletion packages/nodes-base/nodes/ActiveCampaign/ContactTagDescription.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ export const contactTagFields: INodeProperties[] = [
// contactTag:add
// ----------------------------------
{
displayName: 'Tag ID',
displayName: 'Tag Name or ID',
name: 'tagId',
type: 'options',
typeOptions: {
Expand Down
Loading