Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discoverability flow and scopes notice for HTTP Request node #3229

Merged
merged 116 commits into from
May 19, 2022

Commits on Apr 28, 2022

  1. Configuration menu
    Copy the full SHA
    2808ee9 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    d074e52 View commit details
    Browse the repository at this point in the history

Commits on Apr 29, 2022

  1. Configuration menu
    Copy the full SHA
    403e570 View commit details
    Browse the repository at this point in the history

Commits on May 2, 2022

  1. Configuration menu
    Copy the full SHA
    59cb1a2 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    ca0f0df View commit details
    Browse the repository at this point in the history
  3. ⚡ Use constant and version

    ivov committed May 2, 2022
    Configuration menu
    Copy the full SHA
    81aeefa View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    3d5b92b View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    452139f View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    c19df79 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    9b3e9a2 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    bd02a61 View commit details
    Browse the repository at this point in the history

Commits on May 3, 2022

  1. ⚡ Refactor to clean up

    ivov committed May 3, 2022
    Configuration menu
    Copy the full SHA
    791ed95 View commit details
    Browse the repository at this point in the history
  2. 🔀 Merge parent branch

    ivov committed May 3, 2022
    Configuration menu
    Copy the full SHA
    aedbbe5 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    cacd43f View commit details
    Browse the repository at this point in the history
  4. 🔀 Merge parent branch

    ivov committed May 3, 2022
    Configuration menu
    Copy the full SHA
    9bd62c7 View commit details
    Browse the repository at this point in the history
  5. ⚡ Add i18n to option label

    ivov committed May 3, 2022
    Configuration menu
    Copy the full SHA
    fa4f484 View commit details
    Browse the repository at this point in the history
  6. 🔀 Merge parent branch

    ivov committed May 3, 2022
    Configuration menu
    Copy the full SHA
    b290ad5 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    4997569 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    64e08c8 View commit details
    Browse the repository at this point in the history

Commits on May 4, 2022

  1. Configuration menu
    Copy the full SHA
    aa986e1 View commit details
    Browse the repository at this point in the history
  2. 🔥 Remove unneeded property

    ivov committed May 4, 2022
    Configuration menu
    Copy the full SHA
    0d4dbdc View commit details
    Browse the repository at this point in the history
  3. ✏️ Rename arg

    ivov committed May 4, 2022
    Configuration menu
    Copy the full SHA
    5743da3 View commit details
    Browse the repository at this point in the history
  4. 🔥 Remove unused import

    ivov committed May 4, 2022
    Configuration menu
    Copy the full SHA
    2904562 View commit details
    Browse the repository at this point in the history
  5. 🔥 Remove unneeded getters

    ivov committed May 4, 2022
    Configuration menu
    Copy the full SHA
    238565b View commit details
    Browse the repository at this point in the history
  6. 🔥 Remove unused import

    ivov committed May 4, 2022
    Configuration menu
    Copy the full SHA
    9f15c93 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    75eea89 View commit details
    Browse the repository at this point in the history
  8. ⚡ Set up request

    ivov committed May 4, 2022
    Configuration menu
    Copy the full SHA
    77747f8 View commit details
    Browse the repository at this point in the history
  9. 🐛 Fix edge case in endpoint

    ivov committed May 4, 2022
    Configuration menu
    Copy the full SHA
    04997c5 View commit details
    Browse the repository at this point in the history
  10. ⚡ Display scopes alert box

    ivov committed May 4, 2022
    Configuration menu
    Copy the full SHA
    1efedfd View commit details
    Browse the repository at this point in the history

Commits on May 5, 2022

  1. ⏪ Revert "Generalize cred comp positioning"

    This reverts commit 75eea89.
    ivov committed May 5, 2022
    Configuration menu
    Copy the full SHA
    2eaf05e View commit details
    Browse the repository at this point in the history
  2. ⚡ Consolidate HTTPRN check

    ivov committed May 5, 2022
    Configuration menu
    Copy the full SHA
    fec2fc1 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    24b8a56 View commit details
    Browse the repository at this point in the history
  4. 🔥 Remove unused import

    ivov committed May 5, 2022
    Configuration menu
    Copy the full SHA
    cb96d78 View commit details
    Browse the repository at this point in the history
  5. 🔥 Remove unused import

    ivov committed May 5, 2022
    Configuration menu
    Copy the full SHA
    b8357e0 View commit details
    Browse the repository at this point in the history
  6. 🔥 Remove unused class

    ivov committed May 5, 2022
    Configuration menu
    Copy the full SHA
    9151dec View commit details
    Browse the repository at this point in the history
  7. 🔥 Remove unused import

    ivov committed May 5, 2022
    Configuration menu
    Copy the full SHA
    cf54e6a View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    f7cff03 View commit details
    Browse the repository at this point in the history
  9. ✏️ Rename check

    ivov committed May 5, 2022
    Configuration menu
    Copy the full SHA
    bc4aaa6 View commit details
    Browse the repository at this point in the history
  10. 🔥 Remove unused import

    ivov committed May 5, 2022
    Configuration menu
    Copy the full SHA
    43f7e2c View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    760ef5a View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    0a221f3 View commit details
    Browse the repository at this point in the history
  13. 🔀 Merge parent branch

    ivov committed May 5, 2022
    Configuration menu
    Copy the full SHA
    5c11a1b View commit details
    Browse the repository at this point in the history
  14. 🔀 Merge parent branch

    ivov committed May 5, 2022
    Configuration menu
    Copy the full SHA
    d8de1cf View commit details
    Browse the repository at this point in the history
  15. 🔀 Merge parent branch

    ivov committed May 5, 2022
    Configuration menu
    Copy the full SHA
    af455e0 View commit details
    Browse the repository at this point in the history
  16. 🔀 Merge parent branch

    ivov committed May 5, 2022
    Configuration menu
    Copy the full SHA
    eebc6dd View commit details
    Browse the repository at this point in the history
  17. ⚡ Post-merge fixes

    ivov committed May 5, 2022
    Configuration menu
    Copy the full SHA
    e530bd4 View commit details
    Browse the repository at this point in the history
  18. 🔀 Merge scopes branch

    ivov committed May 5, 2022
    Configuration menu
    Copy the full SHA
    a708b31 View commit details
    Browse the repository at this point in the history
  19. ⚡ Add docs link

    ivov committed May 5, 2022
    Configuration menu
    Copy the full SHA
    4450b6c View commit details
    Browse the repository at this point in the history
  20. 🔥 Exclude Notion OAuth cred

    ivov committed May 5, 2022
    Configuration menu
    Copy the full SHA
    6d2bb7e View commit details
    Browse the repository at this point in the history
  21. ✏️ Update copy

    ivov committed May 5, 2022
    Configuration menu
    Copy the full SHA
    e983266 View commit details
    Browse the repository at this point in the history
  22. ✏️ Rename param

    ivov committed May 5, 2022
    Configuration menu
    Copy the full SHA
    5501bc8 View commit details
    Browse the repository at this point in the history
  23. Configuration menu
    Copy the full SHA
    a294201 View commit details
    Browse the repository at this point in the history
  24. ✏️ Update copy

    ivov committed May 5, 2022
    Configuration menu
    Copy the full SHA
    aa89404 View commit details
    Browse the repository at this point in the history

Commits on May 6, 2022

  1. ✏️ Update copy

    ivov committed May 6, 2022
    Configuration menu
    Copy the full SHA
    ba9c85e View commit details
    Browse the repository at this point in the history

Commits on May 9, 2022

  1. Configuration menu
    Copy the full SHA
    216d2e0 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    e543b04 View commit details
    Browse the repository at this point in the history
  3. 🔀 Merge parent branch

    ivov committed May 9, 2022
    Configuration menu
    Copy the full SHA
    83b4225 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    dc8d266 View commit details
    Browse the repository at this point in the history
  5. 🔥 Remove superfluous check

    ivov committed May 9, 2022
    Configuration menu
    Copy the full SHA
    1420386 View commit details
    Browse the repository at this point in the history
  6. ✏️ Break up docstring

    ivov committed May 9, 2022
    Configuration menu
    Copy the full SHA
    e6332a7 View commit details
    Browse the repository at this point in the history
  7. 🎨 Tweak notice styling

    ivov committed May 9, 2022
    Configuration menu
    Copy the full SHA
    2c8805c View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    6d07fc2 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    4a6e78d View commit details
    Browse the repository at this point in the history
  10. 🧪 Update Notice snapshots

    ivov committed May 9, 2022
    Configuration menu
    Copy the full SHA
    0380403 View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    3f2c4a6 View commit details
    Browse the repository at this point in the history
  12. ⏪ Revert 3f2c4a6

    ivov committed May 9, 2022
    Configuration menu
    Copy the full SHA
    1c0cb25 View commit details
    Browse the repository at this point in the history

Commits on May 10, 2022

  1. ⚡ Apply feedback from Product

    ivov committed May 10, 2022
    Configuration menu
    Copy the full SHA
    f06d77d View commit details
    Browse the repository at this point in the history
  2. 🧪 Update snapshot

    ivov committed May 10, 2022
    Configuration menu
    Copy the full SHA
    517079f View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    7b67774 View commit details
    Browse the repository at this point in the history

Commits on May 11, 2022

  1. 🔀 Merge parent branch

    ivov committed May 11, 2022
    Configuration menu
    Copy the full SHA
    c607997 View commit details
    Browse the repository at this point in the history
  2. 🔥 Remove unused import

    ivov committed May 11, 2022
    Configuration menu
    Copy the full SHA
    8e307c6 View commit details
    Browse the repository at this point in the history
  3. 🔥 Remove logging

    ivov committed May 11, 2022
    Configuration menu
    Copy the full SHA
    804896d View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    dc743f8 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    7e961a5 View commit details
    Browse the repository at this point in the history
  6. ⚡ Consolidate notice component

    ivov committed May 11, 2022
    Configuration menu
    Copy the full SHA
    638d93d View commit details
    Browse the repository at this point in the history
  7. ⚡ Apply latest feedback

    ivov committed May 11, 2022
    Configuration menu
    Copy the full SHA
    4ab10d0 View commit details
    Browse the repository at this point in the history
  8. 🧪 Update tests

    ivov committed May 11, 2022
    Configuration menu
    Copy the full SHA
    f961612 View commit details
    Browse the repository at this point in the history
  9. 🧪 Update snapshot

    ivov committed May 11, 2022
    Configuration menu
    Copy the full SHA
    baa4b08 View commit details
    Browse the repository at this point in the history
  10. ✏️ Fix singular version

    ivov committed May 11, 2022
    Configuration menu
    Copy the full SHA
    93bfb7e View commit details
    Browse the repository at this point in the history
  11. 🧪 Finalize tests

    ivov committed May 11, 2022
    Configuration menu
    Copy the full SHA
    4b2ecf8 View commit details
    Browse the repository at this point in the history
  12. ✏️ Rename constant

    ivov committed May 11, 2022
    Configuration menu
    Copy the full SHA
    d6e2895 View commit details
    Browse the repository at this point in the history
  13. 🧪 Expand tests

    ivov committed May 11, 2022
    Configuration menu
    Copy the full SHA
    4f3738d View commit details
    Browse the repository at this point in the history
  14. 🔥 Remove truncate prop

    ivov committed May 11, 2022
    Configuration menu
    Copy the full SHA
    1640e9b View commit details
    Browse the repository at this point in the history

Commits on May 12, 2022

  1. Configuration menu
    Copy the full SHA
    dac800d View commit details
    Browse the repository at this point in the history
  2. 🚚 Move method to component

    ivov committed May 12, 2022
    Configuration menu
    Copy the full SHA
    9cbcf0b View commit details
    Browse the repository at this point in the history
  3. ⚡ Use constant

    ivov committed May 12, 2022
    Configuration menu
    Copy the full SHA
    b445f72 View commit details
    Browse the repository at this point in the history
  4. ⚡ Refactor Notice component

    ivov committed May 12, 2022
    Configuration menu
    Copy the full SHA
    6f0ed1c View commit details
    Browse the repository at this point in the history
  5. 🧪 Update tests

    ivov committed May 12, 2022
    Configuration menu
    Copy the full SHA
    7d7773e View commit details
    Browse the repository at this point in the history
  6. 🔥 Remove unused keys

    ivov committed May 12, 2022
    Configuration menu
    Copy the full SHA
    e475399 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    fc3fc95 View commit details
    Browse the repository at this point in the history
  8. 🔥 Remove unused props

    ivov committed May 12, 2022
    Configuration menu
    Copy the full SHA
    4acf25b View commit details
    Browse the repository at this point in the history
  9. 🎨 Use compact prop

    ivov committed May 12, 2022
    Configuration menu
    Copy the full SHA
    bc58827 View commit details
    Browse the repository at this point in the history
  10. 🧪 Update snapshots

    ivov committed May 12, 2022
    Configuration menu
    Copy the full SHA
    56fd98b View commit details
    Browse the repository at this point in the history
  11. 🚚 Move scopes to store

    ivov committed May 12, 2022
    Configuration menu
    Copy the full SHA
    989ddc1 View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    705d6cd View commit details
    Browse the repository at this point in the history
  13. Configuration menu
    Copy the full SHA
    04eff36 View commit details
    Browse the repository at this point in the history
  14. 🐛 Clear scopes when none

    ivov committed May 12, 2022
    Configuration menu
    Copy the full SHA
    9bf01d8 View commit details
    Browse the repository at this point in the history
  15. ⚡ Add default

    ivov committed May 12, 2022
    Configuration menu
    Copy the full SHA
    5f0d5b9 View commit details
    Browse the repository at this point in the history
  16. Configuration menu
    Copy the full SHA
    9c7a086 View commit details
    Browse the repository at this point in the history

Commits on May 13, 2022

  1. 🔥 Remove test data

    ivov committed May 13, 2022
    Configuration menu
    Copy the full SHA
    f2e901a View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    43d1ffe View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    64db4e4 View commit details
    Browse the repository at this point in the history
  4. ✏️ Rename i18n keys

    ivov committed May 13, 2022
    Configuration menu
    Copy the full SHA
    3d44b18 View commit details
    Browse the repository at this point in the history
  5. ⚡ Refactor OAuth check

    ivov committed May 13, 2022
    Configuration menu
    Copy the full SHA
    6fa4c9c View commit details
    Browse the repository at this point in the history
  6. 🔥 Remove unused key

    ivov committed May 13, 2022
    Configuration menu
    Copy the full SHA
    7991e5a View commit details
    Browse the repository at this point in the history
  7. 🚚 Move OAuth1/2 API to i18n

    ivov committed May 13, 2022
    Configuration menu
    Copy the full SHA
    9a7686f View commit details
    Browse the repository at this point in the history
  8. ⚡ Refactor skipCheck

    ivov committed May 13, 2022
    Configuration menu
    Copy the full SHA
    db8225c View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    a6d9e26 View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    7f304a3 View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    959d57d View commit details
    Browse the repository at this point in the history

Commits on May 16, 2022

  1. ⚡ Implement feedback

    ivov committed May 16, 2022
    Configuration menu
    Copy the full SHA
    4f1c1e9 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    6612848 View commit details
    Browse the repository at this point in the history
  3. 🔀 Merge master

    ivov committed May 16, 2022
    Configuration menu
    Copy the full SHA
    343b148 View commit details
    Browse the repository at this point in the history

Commits on May 19, 2022

  1. 🔀 Merge parent branch

    ivov committed May 19, 2022
    Configuration menu
    Copy the full SHA
    333506a View commit details
    Browse the repository at this point in the history
  2. Refactor to use CredentialsSelect param (#3304)

    * ⚡ Refactor into cred type param
    
    * ⚡ Componentize scopes notice
    
    * 🔥 Remove unused data
    
    * 🔥 Remove unused `loadOptions`
    
    * ⚡ Componentize `NodeCredentialType`
    
    * 🐛 Fix param validation
    
    * 🔥 Remove dup methods
    
    * ⚡ Refactor all references to `isHttpRequestNodeV2`
    
    * 🎨 Fix styling
    
    * 🔥 Remove unused import
    
    * 🔥 Remove unused properties
    
    * 🎨 Fix spacing for Pipedrive Trigger node
    
    * 🎨 Undo Webhook node styling change
    
    * 🔥 Remove unused style
    
    * ⚡ Cover `httpHeaderAuth` edge case
    
    * 🐛 Fix `this.node` reference
    
    * 🚚 Rename to `credentialsSelect`
    
    * 🐛 Fix mistaken renaming
    
    * ⚡ Set one attribute per line
    
    * ⚡ Move condition to instantiation site
    
    * 🚚 Rename prop
    
    * ⚡ Refactor away `prepareScopesNotice`
    
    * ✏️ Rename i18n keys
    
    * ✏️ Update i18n calls
    
    * ✏️ Add more i18n keys
    
    * 🔥 Remove unused props
    
    * ✏️ Add explanatory comment
    
    * ⚡ Adjust check in `hasProxyAuth`
    
    * ⚡ Refactor `credentialSelected` from prop to event
    
    * ⚡ Eventify `valueChanged`, `setFocus`, `onBlur`
    
    * ⚡ Eventify `optionSelected`
    
    * ⚡ Add `noDataExpression`
    
    * 🔥 Remove logging
    
    * 🔥 Remove URL from scopes
    
    * ⚡ Disregard expressions for display
    
    * 🎨 Use CSS modules
    
    * 📘 Tigthen interface
    
    * 🐛 Fix generic auth display
    
    * 🐛 Fix generic auth validation
    
    * 📘 Loosen type
    
    * 🚚 Move event params to end
    
    * ⚡ Generalize reference
    
    * ⚡ Refactor generic auth as `credentialsSelect` param
    
    * ⏪ Restore check for `httpHeaderAuth `
    
    * 🚚 Rename `existing` to `predefined`
    ivov authored May 19, 2022
    Configuration menu
    Copy the full SHA
    2ac022e View commit details
    Browse the repository at this point in the history
  3. Extend metrics for HTTP Request node (#3282)

    * ⚡ Extend metrics
    
    * 🧪 Add tests
    
    * ⚡ Update param names
    ivov authored May 19, 2022
    Configuration menu
    Copy the full SHA
    9389a32 View commit details
    Browse the repository at this point in the history