Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NocoDB Node updated for v0.90.0 - N8N-3411 #3146

Merged
merged 69 commits into from
Aug 3, 2022
Merged

Conversation

mertmit
Copy link
Contributor

@mertmit mertmit commented Apr 16, 2022

  • Added an option to use new API for NocoDB. (Old API will be deprecated on 30 Jun 2022)

@CLAassistant
Copy link

CLAassistant commented Apr 16, 2022

CLA assistant check
All committers have signed the CLA.

@Joffcom Joffcom added community Authored by a community member node/improvement New feature or request labels Apr 16, 2022
@o1lab
Copy link

o1lab commented Apr 24, 2022

With NocoDB version >0.90 the API docs have changed. @janober - if you could pls see the merge through it will help the community. @mertmit can help follow up with any comments to the PR. Thank you

@ed-parsadanyan
Copy link

ed-parsadanyan commented May 2, 2022

Hello. As mentioned in #3170 the issue is still here.
From the commit code I would expect new options in the NocoDB Node (see screenshot), but in the current Docker version of n8n (0.174.0) I don't see any changes in the interface.

image

@o1lab
Copy link

o1lab commented May 2, 2022

but in the current Docker version of n8n (0.174.0)

This PR is yet to be merged - did you expect to still see this in 0.174.0 ?

@ed-parsadanyan
Copy link

but in the current Docker version of n8n (0.174.0)

This PR is yet to be merged - did you expect to still see this in 0.174.0 ?

Oh, I see now, it wasn't merged yet. Hope it will be completed for the next n8n release.

@Joffcom
Copy link
Member

Joffcom commented May 3, 2022

Hey @o1lab & @ed-parsadanyan,

This one has not been reviewed yet it has been on my list for a while but we have been chatting internally about how to deal with API changes like this in a way that can work for existing and future nodes.

I am going to be taking a look today to see how this works out with our new approach.

@o1lab
Copy link

o1lab commented May 3, 2022

@Joffcom : Awesome - thank you.

@fishnux
Copy link

fishnux commented Jun 9, 2022

Any progress on this review for merge, @Joffcom? Thank you!

@Joffcom
Copy link
Member

Joffcom commented Jun 13, 2022

Hey @fishnux,

I was off last week but the good news is we have worked out how to handle API versioning in a way that should scale for all nodes in the future. I will have a few tweaks to make to this which are at the top of my list of things to do so we should be have this mostly wrapped up this week.

@RicardoE105 RicardoE105 changed the title NocoDB Node updated for v0.90.0 NocoDB Node updated for v0.90.0 - N8N-3411 Jul 7, 2022
alexgrozav and others added 23 commits July 27, 2022 17:02
* ⬆️ Upgrade `n8n-workflow` to ESLint 8

* 📦 Update `package-lock.json`

* 📦 Re-update `package-lock.json`
…el-update

💄 Updating onboarding prompt label
@janober janober merged commit d65a9ed into n8n-io:master Aug 3, 2022
@janober
Copy link
Member

janober commented Aug 3, 2022

Thanks a lot. Got merged.

@janober janober added the Upcoming Release Will be part of the upcoming release label Aug 3, 2022
@janober
Copy link
Member

janober commented Aug 3, 2022

Got released with [email protected]

@janober janober removed the Upcoming Release Will be part of the upcoming release label Aug 3, 2022
brianinoa pushed a commit that referenced this pull request Aug 5, 2022
* feat(NocoDB Node): add support for new NocoDB API

* fix(NocoDB Node): fix binary row update on old NocoDB API

* fix(NocoDB Node): fix getAll endpoint

* feat(NocoDB Node): allow xc-token as credential

* fix(NocoDB Node): get all for new api

* feat(NocoDB Node): list options & change to single data apis

* Moved to new format and reduced some code reuse

* Added API Version to Node Settings

* Improvements to remove code reuse and use bulk endpoints

* Added new credentials to close off PR#2909

* Credential testing working

* ⚡ Improvements

* ⚡ Add generic authentication type to credentials

* 🔥 Remove credentials verification

* Fixed Get All not working with manual limit

* Removed json object from project / table fields

* added fix from n8n-4159

* 👕 Fix linting issue

* feat: Improvements to pairedItem

* refactor: Consolidate hoisted package versions (#3724)

* 📦 Consolidate hoisted package versions

* 📦 Update `package-lock.json`

* 📦 Update `package-lock.json`

* 📦 Update `package-lock.json`

* refactor: Upgrade to ESLint 8 (#3722)

* ⬆️ Upgrade to ESLint 8

* 📦 Update package-lock.json

* 👕 Add lint exceptions

* 👕 Add more lint exceptions

* ➖ Remove `tslint` from some packages

* 👕 Except init file

* 📦 Update `package-lock.json`

* 📦 Update `package-lock.json`

* 👕 Add exceptions to new lines coming from `master `

Co-authored-by: Jan Oberhauser <[email protected]>

* refactor: Format all credentials (#3720)

* Apply Prettier to all credentials

* Fix quotes for lint

* 👕 Remove `quotemark` rule

* 👕 Run Prettier to take over quotes

* ⬆️ Upgrade `eslint-plugin-n8n-nodes-base`

* 📦 Update `package-lock.json`

Co-authored-by: Omar Ajoue <[email protected]>
Co-authored-by: Jan Oberhauser <[email protected]>

* fix: Fix node_type property in all events (#3759)

* ⬆️ Update package-lock.json file

* fix(Mautic Node): Fix authentication issue (#3761)

* Fixes mautic credential issue

* removed unused imports

Co-authored-by: Jan Oberhauser <[email protected]>

* fix(AWS DynamoDB Node): Fix expression attribute names (#3763)

* Fix expression attribute names in getAll

* fix: EAN value should be a string, not object

* Removed extra code for working out what credentials are in use

* fix(editor): Fix linking buttons color (#3770)

* fix color of icon

* center buttons

* fix(editor): Restore pindata header colors (#3758)

* 🎨 Restore `color-secondary-tint` colors

* 🔥 Remove typing from JS file

* fix(editor): Fix sticky duplication and position bug (#3755)

* fix bug when inserting sticky

* center sticky on insert

* export as const

* refactor(editor): Move all colors to css variables (#3723)

* update white color

* update white color

* update more whites

* update color

* update curr running

* update text color #555

* update white color

* set search bar colors

* update colors

* update node executing

* update text colors

* update light color

* update theme

* update theme

* update overlays carousel

* update theme vars

* add dark theme tokens

* update text

* update table colors

* fix conflict

* update colors

* feat(Metabase Node): Add Metabase Node (#3033)

* Boilerplate with new node's version for metabse

* Metabases MVP features

* Added new credential for metabse, added custom auth for metabase

* Fixed bug with one enpoint not working

* Clean up code

* Uniformised the renovate token

* Made two example of responses for review

* Fixed lint issues

* Feature add datasources

* Changed output from databases

* Changed questions data output

* Fixed issue when testing credentials with new node format

* Add the possibility to get raw data

* Removed handle for the metabase meta results, changed export's name

* Add binary extraction for the result data

* Fixed binary download issue

* ⚡ Add preAuthentication method to credentials

* Revert "Added new credential for metabse, added custom auth for metabase"

This reverts commit 5f1b760.

* Revert "Added new credential for metabse, added custom auth for metabase"

This reverts commit 5f1b760.

* Added preAuth and fixed autfixable linting rules

* Fixed linting errors

* Linting fixes

* Remove / at the end of url, and add placeholder for cred url

* Make export to Json retun only json and no binary

* Fix lint issues

* Add action and exception for lint rule

* Remove unnecessary credential file

* ⚡ Simplify and cleanup

Co-authored-by: ricardo <[email protected]>
Co-authored-by: Omar Ajoue <[email protected]>
Co-authored-by: Jan Oberhauser <[email protected]>

* fix(editor): Fix spaces bug (#3774)

* refactor(editor): Change welcome sticky content (#3769)

* Updated Welcome sticky content

* Updated welcome sticky thumbnail image

Image was swapped out, used exact same file name + sizing so did not require code changes.

* Replaced welcome sticky thumbnail image

* fix(Fix Rocketchat Node): Fix authentication issue (#3778)

* Add suggested VSCode settings (#3783)

* ⚡ Add suggested settings

* 🔥 Remove app-level setting

* 🎨 Update indentation

* fix(core): Add windows support to import:credentials --separate (#3589)

* feat(Item List Node): Add operation for creating array from input items (#3149)

* 🔨 create array operation

* 🔨 removed semicolumn

* 🔨 updated UI

* ⚡ display option fix

* ⚡ aggregate operation description update, default aggregate item

* refactor: Add Onboarding call prompts (#3682)

* ✨ Implemented initial onboarding call prompt logic

* ✨ Added onboarding call prompt feature environment variable

* ✨ Implemented onboarding session signup modal

* 📈 Added initial telemetry for the onboarding call prompt

* ✔️ Fixing linter error in server.ts

* 💄 Updating onboaring call prompt and modal wording and styling

* ✨ Implemented initial version of fake doors feature

* ✨ Added parameters to onboarding call prompt request

* ✨ Finished implementing fake doors in settings

* 🔨 Updating onboarding call prompt fetching logic (fetching before timeout starts)

* 👌 Updating onboarding call prompt and fake door components based on the front-end review feedback

* ✨ Updated fake doors so they support UI location specification. Added credentials UI fake doors.

* ⚡ Added checkbox to the signup form, improved N8NCheckbox formatting to better handle overflow

* 💄 Moving seignup checkbox label text to i18n file, updating checkbox component css to force text wrap

* ✨ Update API calls to work with the new workflow request and response formats

* 👌 Updating fake door front-end based on the review feedback

* 👌 Updating onboarding call prompt and fake doors UI based in the product feedback

* ✨  Updated onboarding call prompts front-end to work with new endpoints and added new telemetry events

* 🐛 Fixing onboarding call prompts not appearing in first user sessions

* ⚡️ add createdAt to PublicUser

* 👌 Updating onboarding call prompts front-end to work with the latest back-end and addressing latest product review

* ✨ Improving error handling when submitting user emails on signup

* 💄 Updating info text on Logging feature page

* 💄 Updating first onboarding call prompt timeout to 5 minutes

* 💄 Fixing `N8nCheckbox` component font overflow

Co-authored-by: Ben Hesseldieck <[email protected]>

* feat(Kafka Trigger Node): Add additional options (#3600)

* 🔨 additional options to kafka trigger

* ⚡ option for maxInFlightRequests

* ⚡ Small change

Co-authored-by: ricardo <[email protected]>

* fix(editor): Fix pin data in executions when pinData is null. (#3787)

* ⬆️ Update package-lock.json file

* 🔖 Release [email protected]

* ⬆️ Set [email protected] on n8n-core

* 🔖 Release [email protected]

* ⬆️ Set [email protected] and [email protected] on n8n-node-dev

* 🔖 Release [email protected]

* ⬆️ Set [email protected] and [email protected] on n8n-nodes-base

* 🔖 Release [email protected]

* 🔖 Release [email protected]

* ⬆️ Set [email protected] and [email protected] on n8n-editor-ui

* 🔖 Release [email protected]

* ⬆️ Set [email protected], [email protected], [email protected] and [email protected] on n8n

* 🔖 Release [email protected]

* 🔖 Update main package.json to 0.188.0

* 📚 Update CHANGELOG.md with version 0.188.0

* 👕 Adjust line endings for Prettier lintings (#3786)

* build: Use package-lock.json file with custom build

* 💄 Updating onboarding prompt label

* ⬆️ Set [email protected] on n8n-workflow (#3768)

* ⬆️ Upgrade `n8n-workflow` to ESLint 8

* 📦 Update `package-lock.json`

* 📦 Re-update `package-lock.json`

* ⚡ Fix on error behaviour for Delete, Get and Update

Co-authored-by: Jonathan Bennetts <[email protected]>
Co-authored-by: ricardo <[email protected]>
Co-authored-by: Ricardo Espinoza <[email protected]>
Co-authored-by: Jan Oberhauser <[email protected]>
Co-authored-by: Iván Ovejero <[email protected]>
Co-authored-by: Omar Ajoue <[email protected]>
Co-authored-by: Ahsan Virani <[email protected]>
Co-authored-by: Nicholas Penree <[email protected]>
Co-authored-by: Mutasem Aldmour <[email protected]>
Co-authored-by: agobrech <[email protected]>
Co-authored-by: maxtkacz <[email protected]>
Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <[email protected]>
Co-authored-by: Michael Kret <[email protected]>
Co-authored-by: Milorad FIlipović <[email protected]>
Co-authored-by: Ben Hesseldieck <[email protected]>
Co-authored-by: Alex Grozav <[email protected]>
Co-authored-by: Milorad Filipovic <[email protected]>
brianinoa pushed a commit that referenced this pull request Aug 5, 2022
* feat(NocoDB Node): add support for new NocoDB API

* fix(NocoDB Node): fix binary row update on old NocoDB API

* fix(NocoDB Node): fix getAll endpoint

* feat(NocoDB Node): allow xc-token as credential

* fix(NocoDB Node): get all for new api

* feat(NocoDB Node): list options & change to single data apis

* Moved to new format and reduced some code reuse

* Added API Version to Node Settings

* Improvements to remove code reuse and use bulk endpoints

* Added new credentials to close off PR#2909

* Credential testing working

* ⚡ Improvements

* ⚡ Add generic authentication type to credentials

* 🔥 Remove credentials verification

* Fixed Get All not working with manual limit

* Removed json object from project / table fields

* added fix from n8n-4159

* 👕 Fix linting issue

* feat: Improvements to pairedItem

* refactor: Consolidate hoisted package versions (#3724)

* 📦 Consolidate hoisted package versions

* 📦 Update `package-lock.json`

* 📦 Update `package-lock.json`

* 📦 Update `package-lock.json`

* refactor: Upgrade to ESLint 8 (#3722)

* ⬆️ Upgrade to ESLint 8

* 📦 Update package-lock.json

* 👕 Add lint exceptions

* 👕 Add more lint exceptions

* ➖ Remove `tslint` from some packages

* 👕 Except init file

* 📦 Update `package-lock.json`

* 📦 Update `package-lock.json`

* 👕 Add exceptions to new lines coming from `master `

Co-authored-by: Jan Oberhauser <[email protected]>

* refactor: Format all credentials (#3720)

* Apply Prettier to all credentials

* Fix quotes for lint

* 👕 Remove `quotemark` rule

* 👕 Run Prettier to take over quotes

* ⬆️ Upgrade `eslint-plugin-n8n-nodes-base`

* 📦 Update `package-lock.json`

Co-authored-by: Omar Ajoue <[email protected]>
Co-authored-by: Jan Oberhauser <[email protected]>

* fix: Fix node_type property in all events (#3759)

* ⬆️ Update package-lock.json file

* fix(Mautic Node): Fix authentication issue (#3761)

* Fixes mautic credential issue

* removed unused imports

Co-authored-by: Jan Oberhauser <[email protected]>

* fix(AWS DynamoDB Node): Fix expression attribute names (#3763)

* Fix expression attribute names in getAll

* fix: EAN value should be a string, not object

* Removed extra code for working out what credentials are in use

* fix(editor): Fix linking buttons color (#3770)

* fix color of icon

* center buttons

* fix(editor): Restore pindata header colors (#3758)

* 🎨 Restore `color-secondary-tint` colors

* 🔥 Remove typing from JS file

* fix(editor): Fix sticky duplication and position bug (#3755)

* fix bug when inserting sticky

* center sticky on insert

* export as const

* refactor(editor): Move all colors to css variables (#3723)

* update white color

* update white color

* update more whites

* update color

* update curr running

* update text color #555

* update white color

* set search bar colors

* update colors

* update node executing

* update text colors

* update light color

* update theme

* update theme

* update overlays carousel

* update theme vars

* add dark theme tokens

* update text

* update table colors

* fix conflict

* update colors

* feat(Metabase Node): Add Metabase Node (#3033)

* Boilerplate with new node's version for metabse

* Metabases MVP features

* Added new credential for metabse, added custom auth for metabase

* Fixed bug with one enpoint not working

* Clean up code

* Uniformised the renovate token

* Made two example of responses for review

* Fixed lint issues

* Feature add datasources

* Changed output from databases

* Changed questions data output

* Fixed issue when testing credentials with new node format

* Add the possibility to get raw data

* Removed handle for the metabase meta results, changed export's name

* Add binary extraction for the result data

* Fixed binary download issue

* ⚡ Add preAuthentication method to credentials

* Revert "Added new credential for metabse, added custom auth for metabase"

This reverts commit 5f1b760.

* Revert "Added new credential for metabse, added custom auth for metabase"

This reverts commit 5f1b760.

* Added preAuth and fixed autfixable linting rules

* Fixed linting errors

* Linting fixes

* Remove / at the end of url, and add placeholder for cred url

* Make export to Json retun only json and no binary

* Fix lint issues

* Add action and exception for lint rule

* Remove unnecessary credential file

* ⚡ Simplify and cleanup

Co-authored-by: ricardo <[email protected]>
Co-authored-by: Omar Ajoue <[email protected]>
Co-authored-by: Jan Oberhauser <[email protected]>

* fix(editor): Fix spaces bug (#3774)

* refactor(editor): Change welcome sticky content (#3769)

* Updated Welcome sticky content

* Updated welcome sticky thumbnail image

Image was swapped out, used exact same file name + sizing so did not require code changes.

* Replaced welcome sticky thumbnail image

* fix(Fix Rocketchat Node): Fix authentication issue (#3778)

* Add suggested VSCode settings (#3783)

* ⚡ Add suggested settings

* 🔥 Remove app-level setting

* 🎨 Update indentation

* fix(core): Add windows support to import:credentials --separate (#3589)

* feat(Item List Node): Add operation for creating array from input items (#3149)

* 🔨 create array operation

* 🔨 removed semicolumn

* 🔨 updated UI

* ⚡ display option fix

* ⚡ aggregate operation description update, default aggregate item

* refactor: Add Onboarding call prompts (#3682)

* ✨ Implemented initial onboarding call prompt logic

* ✨ Added onboarding call prompt feature environment variable

* ✨ Implemented onboarding session signup modal

* 📈 Added initial telemetry for the onboarding call prompt

* ✔️ Fixing linter error in server.ts

* 💄 Updating onboaring call prompt and modal wording and styling

* ✨ Implemented initial version of fake doors feature

* ✨ Added parameters to onboarding call prompt request

* ✨ Finished implementing fake doors in settings

* 🔨 Updating onboarding call prompt fetching logic (fetching before timeout starts)

* 👌 Updating onboarding call prompt and fake door components based on the front-end review feedback

* ✨ Updated fake doors so they support UI location specification. Added credentials UI fake doors.

* ⚡ Added checkbox to the signup form, improved N8NCheckbox formatting to better handle overflow

* 💄 Moving seignup checkbox label text to i18n file, updating checkbox component css to force text wrap

* ✨ Update API calls to work with the new workflow request and response formats

* 👌 Updating fake door front-end based on the review feedback

* 👌 Updating onboarding call prompt and fake doors UI based in the product feedback

* ✨  Updated onboarding call prompts front-end to work with new endpoints and added new telemetry events

* 🐛 Fixing onboarding call prompts not appearing in first user sessions

* ⚡️ add createdAt to PublicUser

* 👌 Updating onboarding call prompts front-end to work with the latest back-end and addressing latest product review

* ✨ Improving error handling when submitting user emails on signup

* 💄 Updating info text on Logging feature page

* 💄 Updating first onboarding call prompt timeout to 5 minutes

* 💄 Fixing `N8nCheckbox` component font overflow

Co-authored-by: Ben Hesseldieck <[email protected]>

* feat(Kafka Trigger Node): Add additional options (#3600)

* 🔨 additional options to kafka trigger

* ⚡ option for maxInFlightRequests

* ⚡ Small change

Co-authored-by: ricardo <[email protected]>

* fix(editor): Fix pin data in executions when pinData is null. (#3787)

* ⬆️ Update package-lock.json file

* 🔖 Release [email protected]

* ⬆️ Set [email protected] on n8n-core

* 🔖 Release [email protected]

* ⬆️ Set [email protected] and [email protected] on n8n-node-dev

* 🔖 Release [email protected]

* ⬆️ Set [email protected] and [email protected] on n8n-nodes-base

* 🔖 Release [email protected]

* 🔖 Release [email protected]

* ⬆️ Set [email protected] and [email protected] on n8n-editor-ui

* 🔖 Release [email protected]

* ⬆️ Set [email protected], [email protected], [email protected] and [email protected] on n8n

* 🔖 Release [email protected]

* 🔖 Update main package.json to 0.188.0

* 📚 Update CHANGELOG.md with version 0.188.0

* 👕 Adjust line endings for Prettier lintings (#3786)

* build: Use package-lock.json file with custom build

* 💄 Updating onboarding prompt label

* ⬆️ Set [email protected] on n8n-workflow (#3768)

* ⬆️ Upgrade `n8n-workflow` to ESLint 8

* 📦 Update `package-lock.json`

* 📦 Re-update `package-lock.json`

* ⚡ Fix on error behaviour for Delete, Get and Update

Co-authored-by: Jonathan Bennetts <[email protected]>
Co-authored-by: ricardo <[email protected]>
Co-authored-by: Ricardo Espinoza <[email protected]>
Co-authored-by: Jan Oberhauser <[email protected]>
Co-authored-by: Iván Ovejero <[email protected]>
Co-authored-by: Omar Ajoue <[email protected]>
Co-authored-by: Ahsan Virani <[email protected]>
Co-authored-by: Nicholas Penree <[email protected]>
Co-authored-by: Mutasem Aldmour <[email protected]>
Co-authored-by: agobrech <[email protected]>
Co-authored-by: maxtkacz <[email protected]>
Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <[email protected]>
Co-authored-by: Michael Kret <[email protected]>
Co-authored-by: Milorad FIlipović <[email protected]>
Co-authored-by: Ben Hesseldieck <[email protected]>
Co-authored-by: Alex Grozav <[email protected]>
Co-authored-by: Milorad Filipovic <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community Authored by a community member node/improvement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.