Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

N8N-3029 Add Node Type for Wokrflow Stickies/Notes #2910

Merged
merged 2 commits into from
Mar 1, 2022

Conversation

SchnapsterDog
Copy link
Contributor

No description provided.

Comment on lines 21 to 22
inputs: ['main'],
outputs: ['main'],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you remove 'main' from these? since it has no outputs/inputs

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed

Comment on lines 9 to 13
"primaryDocumentation": [
{
"url": "https://docs.n8n.io/nodes/n8n-nodes-base.note/"
}
]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you remove this? devrel team can add this later when page is ready

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed

Comment on lines 15 to 18
"alias": [
"Comments",
"Sticky"
],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did you check with Max on these? this affects search. we should probably add notes as well

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added notes as well. I also checked with Max on this. Will be updated in the later stage per need.

typeOptions: {
rows: 4,
},
default: 'I am a heading. This is how you bold text and this is how you create an inline link.',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you need to change this intro markdown to match designs

  • bold first line
  • add new line between first and second sentence
  • add link to link

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated as suggested

@mutdmour mutdmour changed the base branch from master to stickies March 1, 2022 14:08
@mutdmour mutdmour merged commit 3019087 into stickies Mar 1, 2022
@mutdmour mutdmour deleted the n8n-3029-add-node-type branch March 1, 2022 17:39
@n8n-assistant n8n-assistant bot added n8n team Authored by the n8n team ui Enhancement in /editor-ui or /design-system labels May 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
n8n team Authored by the n8n team ui Enhancement in /editor-ui or /design-system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants