Templates Bugs / Fixed Various Bugs / Multiply Api Request, Carousel Gradient, Core Nodes Filters #2832
Conversation
…Gradient, Core Nodes Filters ...
| @@ -21,7 +24,12 @@ | |||
| </div> | |||
| <div> | |||
| <div :class="$style.image"> | |||
| <workflow-preview v-if="showPreview" :workflow="template.workflow" @close="onHidePreview" :loading="loading"/> | |||
| <workflow-preview | |||
There was a problem hiding this comment.
nitpick - WorkflowPreview for our own components. easier to search for and more consistent with our editor components. let's keep snake case for our element-ui/design system components
| @@ -102,6 +103,7 @@ addIcon(faArrowLeft); | |||
| addIcon(faArrowRight); | |||
| addIcon(faAt); | |||
| addIcon(faBook); | |||
| addIcon(faBoxOpen); | |||
There was a problem hiding this comment.
do you also need to remove the icon we added?
There was a problem hiding this comment.
In the latest push the faShapes icon is removed.
| if (vnode.context.$props.infinityScroll && vnode.context.$route.name === 'TemplatesView') { | ||
| if ( | ||
| vnode.context.$props.infinityScroll && | ||
| vnode.context.$route.name === 'TemplatesView' && |
There was a problem hiding this comment.
this should be a prop infiniteScrollEnabled instead based on the page we are on, instead of checking the route
There was a problem hiding this comment.
Updated as suggested and infiniteScrollEnabled prop refactored as suggested as well.
…infiniteScrollEnabled Prop + updated infiniterScroll functinality
… and WebhookRespond from Nodes, Added Box for showing more nodes inside TemplateList, Updated NewWorkflowButton to primary, Fixed Markdown issue with Code
…d, Updated the Logic
| justify-content: center; | ||
| align-items: center; | ||
| background: var(--color-background-light); | ||
| border: $--version-card-border; |
There was a problem hiding this comment.
I will update this. I know that I have not to use this $--version-card-border here :)
[x] Change menu icon to
[x] Change z-index of traverse carousel actions (left + right chevrons) so they’re above the “fade to background” layer.
[x] Change menu icon to
[x]Offset the position of the traverse carousel actions, so they sit outside the column. Offset them so that the edge of the action touches column
[x] Replace “end of results” string with Share your own useful workflowsherethrough your n8n.io account
[x] Still showing core nodes next to non-core nodes
[x] Infitiny Scroll - Multiply API Request fix. content flashing on infinite scroll (probably related to duplicate graphql requets)
[x] Change “collection” subtitle on collection page to regular weight; Add same subtitle for workflow individual page: Workflow (same position etc as on collection page)
[x] Change “Apps in this collection” to This collection features
[x] Change height of WF preview iframe to 500px
[x] Scroll to Top Fix. When clicking on a template while scrolled in the main view,
[x] Fix existing iframe rendering issue (start node not zooming etc)
[x] Help menu icons are off (in both expanded and popup)
[x] Bug buttons Carousel: open search page, search for “maxt” and clear the searchbar
[x] Change “new blank workflow” button to primary type, from current secondary
[x] Total count of node icons should exceed 5 icons (5 includes the “+X”; so only 4 actual node icons)
[x] Filter Start Node and Webhook Respond Node
[x] Created Constants which is included into functions to filter the nodes that we want in the future
[x] If there are no collections found (or no workflows found) hide the section
[x] Categories Sidebar is moving because of the long names of some Categories Names