N8n 2954 use env variables on fe to customize #2823
Conversation
…://github.com/n8n-io/n8n into n8n-2954-use-env-variables-on-fe-to-customize
packages/editor-ui/src/App.vue
Outdated
| title: 'Error connecting to n8n', | ||
| message: | ||
| 'Could not connect to server. <a onclick="window.location.reload(false);">Refresh</a> to try again', |
There was a problem hiding this comment.
these should be localized. the reason these were not localized in UM is because this was implemented before i18n was added
packages/editor-ui/src/constants.ts
Outdated
| @@ -39,7 +39,7 @@ export const BREAKPOINT_XL = 1920; | |||
|
|
|||
|
|
|||
| // templates | |||
| export const TEMPLATES_BASE_URL = `https://api-staging.n8n.io/`; | |||
| export const TEMPLATES_BASE_URL = `https://api.n8n.io/`; | |||
There was a problem hiding this comment.
is this used anywhere? why cannot we delete this? if this is still used by versions, let's rename it to that
There was a problem hiding this comment.
We are using in few places. For WorkflowTemplates (getWorkflowTemplates() inside api/workflows.js file) and ValueSurvey & ContactPrompt modals.
For the first one, maybe we can use the same thing that we are using for templates? Than I can change the constant name just for the two modals.
There was a problem hiding this comment.
Updated as per today discussion.
packages/editor-ui/src/router.ts
Outdated
| @@ -33,7 +33,7 @@ export default new Router({ | |||
| }, | |||
| }, | |||
| { | |||
| path: '/templates/:id', | |||
| path: '/template/:id', | |||
There was a problem hiding this comment.
can we make this back to /templates
Templates preview fixes
No description provided.