Skip to content

ci: Prevent new version patches, if only content is ci changes #27329

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Matsuuu merged 2 commits into from
Mar 20, 2026
+19 −6
Merged

ci: Prevent new version patches, if only content is ci changes #27329

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6f89b19
ci: Prevent new version patches, if only content is ci changes
Matsuuu Mar 20, 2026
61e51ca
ci: Better parsing for commits
Matsuuu Mar 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 18 additions & 5 deletions .github/scripts/determine-release-candidate-branch-for-track.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
import {
countCommitsBetweenRefs,
ensureEnvVar,
listCommitsBetweenRefs,
resolveRcBranchForTrack,
Expand All @@ -25,12 +24,26 @@ function main() {
console.log(`Commits between ${releaseCandidateBranch} and ${currentTag.tag}:`);
console.log(listCommitsBetweenRefs(releaseCandidateBranch, currentTag.tag));

const commitCount = countCommitsBetweenRefs(releaseCandidateBranch, currentTag.tag);
const commitList = listCommitsBetweenRefs(releaseCandidateBranch, currentTag.tag)
.split('\n')
.filter((commit) => commit.trim().length > 0);
Comment thread
Matsuuu marked this conversation as resolved.
const actionableCommitList = filterActionableCommits(commitList);

writeGithubOutput({
const output = {
release_candidate_branch: releaseCandidateBranch,
should_update: commitCount > 0 ? 'true' : 'false',
});
should_update: actionableCommitList.length > 0 ? 'true' : 'false',
};

console.log(output);

writeGithubOutput(output);
}

/**
* @param { string[] } commitList
* */
export function filterActionableCommits(commitList) {
return commitList.filter((commit) => !commit.trimStart().startsWith('ci:'));
Comment thread
Matsuuu marked this conversation as resolved.
}

// only run when executed directly, not when imported by tests
Expand Down
2 changes: 1 addition & 1 deletion .github/scripts/github-helpers.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -286,7 +286,7 @@ export function listTagsPointingAt(commit) {
* @param {string} to
*/
export function listCommitsBetweenRefs(from, to) {
return sh('git', ['--no-pager', 'log', '--format="- %s (%h)', `${to}..origin/${from}`]);
return sh('git', ['--no-pager', 'log', '--format=%s (%h)', `${to}..origin/${from}`]);
}

/**
Expand Down
Loading