Skip to content

fix(editor): Adjust external secrets input styling (backport to release-candidate/2.13.x) - #27164

Merged
heymynameisrob merged 1 commit into
release-candidate/2.13.xfrom
backport-27110-to-release-candidate/2.13.x
Mar 17, 2026
Merged

heymynameisrob merged 1 commit into
release-candidate/2.13.xfrom
backport-27110-to-release-candidate/2.13.x

Conversation

@n8n-assistant

@n8n-assistant n8n-assistant Bot commented Mar 17, 2026

Copy link
Copy Markdown
Contributor

Description

Backport of #27110 to release-candidate/2.13.x.

Checklist for the author (@heymynameisrob) to go through.

  • Review the backport changes
  • Fix possible conflicts
  • Merge to target branch

After this PR has been merged, it will be picked up in the next patch release for release track.

Original description

Summary

  • Align external secrets input placeholder and disabled text styling with design tokens.
  • Add horizontal padding to the external secrets connection modal content to prevent input borders from clipping.
Before After
before image after image

Related Linear tickets, Github issues, and Community forum posts

Review / Merge checklist

  • PR title and summary are descriptive. (conventions)
  • Docs updated or follow-up ticket created.
  • Tests included.
  • PR Labeled with release/backport (if the PR is an urgent fix that needs to be backported)

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 2 files

Architecture diagram
sequenceDiagram
    participant User
    participant Editor as Editor UI
    participant Modal as Secrets Provider Modal (EE)
    participant DS_Input as N8nInput (Design System)
    participant Tokens as Design Tokens

    Note over Editor,Tokens: Runtime Style Resolution for External Secrets

    User->>Editor: Click "Add Secret Provider"
    Editor->>Modal: Mount SecretsProviderConnectionModal
    
    rect rgb(23, 37, 84)
        Note right of Modal: Layout Adjustment
        Modal->>Modal: CHANGED: Apply padding-inline (--spacing--xs)
    end

    Modal->>DS_Input: Render Input (Credentials/Config)
    
    alt Input is empty or disabled
        DS_Input->>Tokens: Request color value
        
        rect rgb(23, 37, 84)
            Note right of Tokens: Styling Adjustment
            Tokens-->>DS_Input: CHANGED: Return --color--text--tint-1
        end

        DS_Input->>DS_Input: Apply color to ::placeholder or :disabled
    end

    DS_Input-->>Modal: Return Styled Component
    Modal-->>User: Display Modal (No border clipping, updated text colors)
Loading

@codecov

codecov Bot commented Mar 17, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@codecov

codecov Bot commented Mar 17, 2026

Copy link
Copy Markdown

Bundle Report

Changes will increase total bundle size by 8 bytes (0.0%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
editor-ui-esm 42.78MB 8 bytes (0.0%) ⬆️

Affected Assets, Files, and Routes:

view changes for bundle: editor-ui-esm

Assets Changed:

Asset Name Size Change Total Size Change (%)
assets/worker-*.js -2.93MB 13.37kB -99.55%
assets/worker-*.js 2.93MB 2.95MB 21924.81% ⚠️
assets/index-*.css 20 bytes 796.06kB 0.0%
assets/src-*.css -12 bytes 480.83kB -0.0%
assets/expression-*.js -17 bytes 209 bytes -7.52%
assets/expression-*.js 11 bytes 220 bytes 5.26% ⚠️
assets/expression-*.js 6 bytes 226 bytes 2.73%

@heymynameisrob
heymynameisrob enabled auto-merge (squash) March 17, 2026 15:41
@heymynameisrob
heymynameisrob merged commit 44c565b into release-candidate/2.13.x Mar 17, 2026
82 of 86 checks passed
@heymynameisrob
heymynameisrob deleted the backport-27110-to-release-candidate/2.13.x branch March 17, 2026 15:42
This was referenced Mar 18, 2026
@n8n-assistant

n8n-assistant Bot commented Mar 18, 2026

Copy link
Copy Markdown
Contributor Author

Got released with n8n@2.13.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant