fix(editor): Adjust external secrets input styling (backport to release-candidate/2.13.x) - #27164
Merged
heymynameisrob merged 1 commit intoMar 17, 2026
Conversation
(cherry picked from commit 9854450)
4 tasks
Contributor
There was a problem hiding this comment.
No issues found across 2 files
Architecture diagram
sequenceDiagram
participant User
participant Editor as Editor UI
participant Modal as Secrets Provider Modal (EE)
participant DS_Input as N8nInput (Design System)
participant Tokens as Design Tokens
Note over Editor,Tokens: Runtime Style Resolution for External Secrets
User->>Editor: Click "Add Secret Provider"
Editor->>Modal: Mount SecretsProviderConnectionModal
rect rgb(23, 37, 84)
Note right of Modal: Layout Adjustment
Modal->>Modal: CHANGED: Apply padding-inline (--spacing--xs)
end
Modal->>DS_Input: Render Input (Credentials/Config)
alt Input is empty or disabled
DS_Input->>Tokens: Request color value
rect rgb(23, 37, 84)
Note right of Tokens: Styling Adjustment
Tokens-->>DS_Input: CHANGED: Return --color--text--tint-1
end
DS_Input->>DS_Input: Apply color to ::placeholder or :disabled
end
DS_Input-->>Modal: Return Styled Component
Modal-->>User: Display Modal (No border clipping, updated text colors)
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Bundle ReportChanges will increase total bundle size by 8 bytes (0.0%) ⬆️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: editor-ui-esmAssets Changed:
|
heymynameisrob
approved these changes
Mar 17, 2026
heymynameisrob
enabled auto-merge (squash)
March 17, 2026 15:41
heymynameisrob
merged commit Mar 17, 2026
44c565b
into
release-candidate/2.13.x
82 of 86 checks passed
Contributor
Author
|
Got released with |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Backport of #27110 to
release-candidate/2.13.x.Checklist for the author (@heymynameisrob) to go through.
After this PR has been merged, it will be picked up in the next patch release for release track.
Original description
Summary
Related Linear tickets, Github issues, and Community forum posts
Review / Merge checklist
release/backport(if the PR is an urgent fix that needs to be backported)