Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(n8n Form Node): Use https to load google fonts #11948

Merged
merged 1 commit into from
Nov 28, 2024
Merged

Conversation

netroy
Copy link
Member

@netroy netroy commented Nov 28, 2024

Summary

PR title says it all.

Related Linear tickets, Github issues, and Community forum posts

Fixes #11947
NODE-2094

Review / Merge checklist

  • PR title and summary are descriptive. (conventions)
  • Docs updated or follow-up ticket created.
  • Tests included.
  • PR Labeled with release/backport (if the PR is an urgent fix that needs to be backported)

Copy link
Member

@Joffcom Joffcom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@n8n-assistant n8n-assistant bot added core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team node/improvement New feature or request labels Nov 28, 2024
Copy link

cypress bot commented Nov 28, 2024

n8n    Run #8141

Run Properties:  status check passed Passed #8141  •  git commit ac5979a770: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 netroy 🗃️ e2e/*
Project n8n
Branch Review fix-NODE-2094
Run status status check passed Passed #8141
Run duration 04m 38s
Commit git commit ac5979a770: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 netroy 🗃️ e2e/*
Committer कारतोफ्फेलस्क्रिप्ट™
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 478
View all changes introduced in this branch ↗︎

Copy link
Contributor

✅ All Cypress E2E specs passed

Copy link

codecov bot commented Nov 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!

@netroy netroy merged commit eccd924 into master Nov 28, 2024
35 checks passed
@netroy netroy deleted the fix-NODE-2094 branch November 28, 2024 13:14
@github-actions github-actions bot mentioned this pull request Dec 4, 2024
@janober
Copy link
Member

janober commented Dec 4, 2024

Got released with [email protected]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team node/improvement New feature or request Released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The form page cannot be displayed properly on some highly secure mobile devices.
3 participants