Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Code Node): Warning if pairedItem absent or could not be auto mapped #11737

Merged

Conversation

michael-radency
Copy link
Contributor

@michael-radency michael-radency commented Nov 14, 2024

Summary

add warning if paired item not returned or could not be mapped automatically
image

Related Linear tickets, Github issues, and Community forum posts

https://linear.app/n8n/issue/NODE-2008/paired-item-make-code-node-errors-easier-to-debug

@michael-radency michael-radency added node/improvement New feature or request n8n team Authored by the n8n team labels Nov 14, 2024
Copy link

codecov bot commented Nov 14, 2024

Copy link
Contributor

@ShireenMissi ShireenMissi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested manually and it all works as expected 🎉

ShireenMissi
ShireenMissi previously approved these changes Nov 27, 2024
Copy link
Contributor

@ShireenMissi ShireenMissi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

Copy link
Contributor

⚠️ Some Cypress E2E specs are failing, please fix them before merging

Copy link

cypress bot commented Nov 27, 2024

n8n    Run #8135

Run Properties:  status check passed Passed #8135  •  git commit 3a5bd12945: 🌳 master 🖥️ browsers:node18.12.0-chrome107 🤖 PR User 🗃️ e2e/*
Project n8n
Branch Review master
Run status status check passed Passed #8135
Run duration 04m 50s
Commit git commit 3a5bd12945: 🌳 master 🖥️ browsers:node18.12.0-chrome107 🤖 PR User 🗃️ e2e/*
Committer Michael Kret
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 478
View all changes introduced in this branch ↗︎

ShireenMissi
ShireenMissi previously approved these changes Nov 27, 2024
Copy link
Contributor

✅ All Cypress E2E specs passed

@ShireenMissi ShireenMissi merged commit 3a5bd12 into master Nov 27, 2024
36 checks passed
@ShireenMissi ShireenMissi deleted the node-2008-paired-item-make-code-node-errors-easier-to-debug branch November 27, 2024 16:31
despairblue pushed a commit that referenced this pull request Nov 28, 2024
@github-actions github-actions bot mentioned this pull request Dec 4, 2024
@janober
Copy link
Member

janober commented Dec 4, 2024

Got released with [email protected]

riascho pushed a commit that referenced this pull request Jan 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
n8n team Authored by the n8n team node/improvement New feature or request Released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants