fix(core): Allow Azure's SAML metadata XML containing WS-Federation nodes to pass validation #11724
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…odes to pass validation This only allows passing the xml validation against the XSDs. It does not use the WS-Federation nodes for anything. But this allows using the metadata URL to keep the metadata up to date automatically opposed to copy and pasting the xml from Azure, while removing the WS-Federation nodes.
n8n-assistant
bot
added
core
despairblue
added a commit
to n8n-io/n8n-docs
that referenced
this pull request
Nov 13, 2024
This is not necessary anymore once n8n-io/n8n#11724 is merged.
Codecov ReportAll modified and coverable lines are covered by tests ✅ 📢 Thoughts on this report? Let us know! |
netroy
requested changes
Nov 14, 2024
Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <[email protected]>
n8n
|
||||||||||||||||||||||||||||
| Project |
n8n
|
| Branch Review |
help-643-urgent-not-able-to-login-into-n8n-after-upgrading-version
|
| Run status |
|
| Run duration | 04m 20s |
| Commit |
|
| Committer | Danny Martini |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
0
|
Skipped
|
0
|
Passing
|
470
|
| View all changes introduced in this branch ↗︎ | |
|
✅ All Cypress E2E specs passed |
despairblue
deleted the
help-643-urgent-not-able-to-login-into-n8n-after-upgrading-version
branch
Merged
|
Got released with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Azure is adding WS Federation data to it's metadata XML.
n8n didn't have the right xsd's to validate that xml correctly even though the rest of the metadata file contains everything else we need to SAML.
This PR adds the schemas and tests for the validation logic, making sure azure's format is now supported.
This only allows passing the xml validation against the XSDs. It does not use the WS-Federation nodes for anything.
Before:
After:
Related Linear tickets, Github issues, and Community forum posts
Docs PR: n8n-io/n8n-docs#2617
Linear Ticket: https://linear.app/n8n/issue/HELP-643/urgent-not-able-to-login-into-n8n-after-upgrading-version#comment-1886eaa9
Review / Merge checklist
release/backport(if the PR is an urgent fix that needs to be backported)