fix: Fixed pin data in executions when pinData is null. #3787

alexgrozav · 2022-07-27T13:22:35Z

Fixes bug causing all execution nodes to appear as pinned.

Reproduction steps: Set workflow.pinData to null in the store.

ivov

For repro, I pinned a node and set workflow.pinData to null in the store via the Firefox Vue extension, causing the node output to become unpinned. Still unclear how to reproduce this normally.

ivov · 2022-07-27T13:45:25Z

packages/editor-ui/src/store.ts

@@ -652,9 +655,9 @@ export const store = new Vuex.Store({
 		},

 		setWorkflowPinData(state, pinData: IPinData) {
-			Vue.set(state.workflow, 'pinData', pinData);
+			Vue.set(state.workflow, 'pinData', pinData || {});


Suggestion: setWorkflowPinData(state, pinData: IPinData = {}) { ... } instead of setting them below.

On second thought, maybe null does not trigger the default arg.

ivov · 2022-07-27T13:49:15Z

packages/editor-ui/src/store.ts

 			}

+			Vue.set(state.workflow.pinData!, payload.node.name, undefined);


Non-actionable: Would be nice if Vue.set() were smart enough to create missing intermediate properties to avoid the boilerplate. Also I wish TS were able to pick up that state.workflow.pinData is defined via Vue.set().

janober · 2022-07-27T15:02:53Z

Thanks a lot. Got merged

janober · 2022-07-27T16:17:00Z

Got released with [email protected]

* feat(NocoDB Node): add support for new NocoDB API * fix(NocoDB Node): fix binary row update on old NocoDB API * fix(NocoDB Node): fix getAll endpoint * feat(NocoDB Node): allow xc-token as credential * fix(NocoDB Node): get all for new api * feat(NocoDB Node): list options & change to single data apis * Moved to new format and reduced some code reuse * Added API Version to Node Settings * Improvements to remove code reuse and use bulk endpoints * Added new credentials to close off PR#2909 * Credential testing working * ⚡ Improvements * ⚡ Add generic authentication type to credentials * 🔥 Remove credentials verification * Fixed Get All not working with manual limit * Removed json object from project / table fields * added fix from n8n-4159 * 👕 Fix linting issue * feat: Improvements to pairedItem * refactor: Consolidate hoisted package versions (#3724) * 📦 Consolidate hoisted package versions * 📦 Update `package-lock.json` * 📦 Update `package-lock.json` * 📦 Update `package-lock.json` * refactor: Upgrade to ESLint 8 (#3722) * ⬆️ Upgrade to ESLint 8 * 📦 Update package-lock.json * 👕 Add lint exceptions * 👕 Add more lint exceptions * ➖ Remove `tslint` from some packages * 👕 Except init file * 📦 Update `package-lock.json` * 📦 Update `package-lock.json` * 👕 Add exceptions to new lines coming from `master ` Co-authored-by: Jan Oberhauser <[email protected]> * refactor: Format all credentials (#3720) * Apply Prettier to all credentials * Fix quotes for lint * 👕 Remove `quotemark` rule * 👕 Run Prettier to take over quotes * ⬆️ Upgrade `eslint-plugin-n8n-nodes-base` * 📦 Update `package-lock.json` Co-authored-by: Omar Ajoue <[email protected]> Co-authored-by: Jan Oberhauser <[email protected]> * fix: Fix node_type property in all events (#3759) * ⬆️ Update package-lock.json file * fix(Mautic Node): Fix authentication issue (#3761) * Fixes mautic credential issue * removed unused imports Co-authored-by: Jan Oberhauser <[email protected]> * fix(AWS DynamoDB Node): Fix expression attribute names (#3763) * Fix expression attribute names in getAll * fix: EAN value should be a string, not object * Removed extra code for working out what credentials are in use * fix(editor): Fix linking buttons color (#3770) * fix color of icon * center buttons * fix(editor): Restore pindata header colors (#3758) * 🎨 Restore `color-secondary-tint` colors * 🔥 Remove typing from JS file * fix(editor): Fix sticky duplication and position bug (#3755) * fix bug when inserting sticky * center sticky on insert * export as const * refactor(editor): Move all colors to css variables (#3723) * update white color * update white color * update more whites * update color * update curr running * update text color #555 * update white color * set search bar colors * update colors * update node executing * update text colors * update light color * update theme * update theme * update overlays carousel * update theme vars * add dark theme tokens * update text * update table colors * fix conflict * update colors * feat(Metabase Node): Add Metabase Node (#3033) * Boilerplate with new node's version for metabse * Metabases MVP features * Added new credential for metabse, added custom auth for metabase * Fixed bug with one enpoint not working * Clean up code * Uniformised the renovate token * Made two example of responses for review * Fixed lint issues * Feature add datasources * Changed output from databases * Changed questions data output * Fixed issue when testing credentials with new node format * Add the possibility to get raw data * Removed handle for the metabase meta results, changed export's name * Add binary extraction for the result data * Fixed binary download issue * ⚡ Add preAuthentication method to credentials * Revert "Added new credential for metabse, added custom auth for metabase" This reverts commit 5f1b760. * Revert "Added new credential for metabse, added custom auth for metabase" This reverts commit 5f1b760. * Added preAuth and fixed autfixable linting rules * Fixed linting errors * Linting fixes * Remove / at the end of url, and add placeholder for cred url * Make export to Json retun only json and no binary * Fix lint issues * Add action and exception for lint rule * Remove unnecessary credential file * ⚡ Simplify and cleanup Co-authored-by: ricardo <[email protected]> Co-authored-by: Omar Ajoue <[email protected]> Co-authored-by: Jan Oberhauser <[email protected]> * fix(editor): Fix spaces bug (#3774) * refactor(editor): Change welcome sticky content (#3769) * Updated Welcome sticky content * Updated welcome sticky thumbnail image Image was swapped out, used exact same file name + sizing so did not require code changes. * Replaced welcome sticky thumbnail image * fix(Fix Rocketchat Node): Fix authentication issue (#3778) * Add suggested VSCode settings (#3783) * ⚡ Add suggested settings * 🔥 Remove app-level setting * 🎨 Update indentation * fix(core): Add windows support to import:credentials --separate (#3589) * feat(Item List Node): Add operation for creating array from input items (#3149) * 🔨 create array operation * 🔨 removed semicolumn * 🔨 updated UI * ⚡ display option fix * ⚡ aggregate operation description update, default aggregate item * refactor: Add Onboarding call prompts (#3682) * ✨ Implemented initial onboarding call prompt logic * ✨ Added onboarding call prompt feature environment variable * ✨ Implemented onboarding session signup modal * 📈 Added initial telemetry for the onboarding call prompt * ✔️ Fixing linter error in server.ts * 💄 Updating onboaring call prompt and modal wording and styling * ✨ Implemented initial version of fake doors feature * ✨ Added parameters to onboarding call prompt request * ✨ Finished implementing fake doors in settings * 🔨 Updating onboarding call prompt fetching logic (fetching before timeout starts) * 👌 Updating onboarding call prompt and fake door components based on the front-end review feedback * ✨ Updated fake doors so they support UI location specification. Added credentials UI fake doors. * ⚡ Added checkbox to the signup form, improved N8NCheckbox formatting to better handle overflow * 💄 Moving seignup checkbox label text to i18n file, updating checkbox component css to force text wrap * ✨ Update API calls to work with the new workflow request and response formats * 👌 Updating fake door front-end based on the review feedback * 👌 Updating onboarding call prompt and fake doors UI based in the product feedback * ✨ Updated onboarding call prompts front-end to work with new endpoints and added new telemetry events * 🐛 Fixing onboarding call prompts not appearing in first user sessions * ⚡️ add createdAt to PublicUser * 👌 Updating onboarding call prompts front-end to work with the latest back-end and addressing latest product review * ✨ Improving error handling when submitting user emails on signup * 💄 Updating info text on Logging feature page * 💄 Updating first onboarding call prompt timeout to 5 minutes * 💄 Fixing `N8nCheckbox` component font overflow Co-authored-by: Ben Hesseldieck <[email protected]> * feat(Kafka Trigger Node): Add additional options (#3600) * 🔨 additional options to kafka trigger * ⚡ option for maxInFlightRequests * ⚡ Small change Co-authored-by: ricardo <[email protected]> * fix(editor): Fix pin data in executions when pinData is null. (#3787) * ⬆️ Update package-lock.json file * 🔖 Release [email protected] * ⬆️ Set [email protected] on n8n-core * 🔖 Release [email protected] * ⬆️ Set [email protected] and [email protected] on n8n-node-dev * 🔖 Release [email protected] * ⬆️ Set [email protected] and [email protected] on n8n-nodes-base * 🔖 Release [email protected] * 🔖 Release [email protected] * ⬆️ Set [email protected] and [email protected] on n8n-editor-ui * 🔖 Release [email protected] * ⬆️ Set [email protected], [email protected], [email protected] and [email protected] on n8n * 🔖 Release [email protected] * 🔖 Update main package.json to 0.188.0 * 📚 Update CHANGELOG.md with version 0.188.0 * 👕 Adjust line endings for Prettier lintings (#3786) * build: Use package-lock.json file with custom build * 💄 Updating onboarding prompt label * ⬆️ Set [email protected] on n8n-workflow (#3768) * ⬆️ Upgrade `n8n-workflow` to ESLint 8 * 📦 Update `package-lock.json` * 📦 Re-update `package-lock.json` * ⚡ Fix on error behaviour for Delete, Get and Update Co-authored-by: Jonathan Bennetts <[email protected]> Co-authored-by: ricardo <[email protected]> Co-authored-by: Ricardo Espinoza <[email protected]> Co-authored-by: Jan Oberhauser <[email protected]> Co-authored-by: Iván Ovejero <[email protected]> Co-authored-by: Omar Ajoue <[email protected]> Co-authored-by: Ahsan Virani <[email protected]> Co-authored-by: Nicholas Penree <[email protected]> Co-authored-by: Mutasem Aldmour <[email protected]> Co-authored-by: agobrech <[email protected]> Co-authored-by: maxtkacz <[email protected]> Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <[email protected]> Co-authored-by: Michael Kret <[email protected]> Co-authored-by: Milorad FIlipović <[email protected]> Co-authored-by: Ben Hesseldieck <[email protected]> Co-authored-by: Alex Grozav <[email protected]> Co-authored-by: Milorad Filipovic <[email protected]>

fix: Fixed pin data in executions when pinData is null.

f3abf2e

alexgrozav requested a review from ivov July 27, 2022 13:22

n8n-assistant bot added n8n team Authored by the n8n team ui Enhancement in /editor-ui or /design-system labels Jul 27, 2022

ivov reviewed Jul 27, 2022

View reviewed changes

janober merged commit 30c0f21 into master Jul 27, 2022

janober deleted the n8n-4230-fix-pin-data-bug-in-executions branch July 27, 2022 15:02

janober added the Upcoming Release Will be part of the upcoming release label Jul 27, 2022

janober removed the Upcoming Release Will be part of the upcoming release label Jul 27, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: Fixed pin data in executions when pinData is null. #3787

fix: Fixed pin data in executions when pinData is null. #3787

alexgrozav commented Jul 27, 2022

ivov left a comment •

edited

Loading

ivov Jul 27, 2022

ivov Jul 27, 2022

ivov Jul 27, 2022

janober commented Jul 27, 2022

janober commented Jul 27, 2022

		}

		Vue.set(state.workflow.pinData!, payload.node.name, undefined);

fix: Fixed pin data in executions when pinData is null. #3787

fix: Fixed pin data in executions when pinData is null. #3787

Conversation

alexgrozav commented Jul 27, 2022

ivov left a comment • edited Loading

Choose a reason for hiding this comment

ivov Jul 27, 2022

Choose a reason for hiding this comment

ivov Jul 27, 2022

Choose a reason for hiding this comment

ivov Jul 27, 2022

Choose a reason for hiding this comment

janober commented Jul 27, 2022

janober commented Jul 27, 2022

ivov left a comment •

edited

Loading