Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(editor): Use optional chaining for all members in execution data when using the debug feature #12024

Merged
merged 2 commits into from
Dec 4, 2024

Conversation

cstuncsik
Copy link
Contributor

@cstuncsik cstuncsik commented Dec 3, 2024

Summary

Execution run data by nodes can be an empty array.

Related Linear tickets, Github issues, and Community forum posts

PAY-2074

Review / Merge checklist

  • PR title and summary are descriptive.
  • Tests included.
  • PR Labeled with release/backport

@n8n-assistant n8n-assistant bot added n8n team Authored by the n8n team ui Enhancement in /editor-ui or /design-system labels Dec 3, 2024
Copy link

codecov bot commented Dec 3, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...editor-ui/src/composables/useExecutionDebugging.ts 0.00% 0 Missing and 1 partial ⚠️

📢 Thoughts on this report? Let us know!

@cstuncsik cstuncsik requested a review from r00gm December 3, 2024 15:53
Copy link

cypress bot commented Dec 4, 2024

n8n    Run #8200

Run Properties:  status check passed Passed #8200  •  git commit 1068816c2d: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 cstuncsik 🗃️ e2e/*
Project n8n
Branch Review pay-2074-typeerror-_bmain-is-undefined
Run status status check passed Passed #8200
Run duration 04m 38s
Commit git commit 1068816c2d: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 cstuncsik 🗃️ e2e/*
Committer Csaba Tuncsik
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 478
View all changes introduced in this branch ↗︎

Copy link
Contributor

github-actions bot commented Dec 4, 2024

✅ All Cypress E2E specs passed

@cstuncsik cstuncsik merged commit 67aa0c9 into master Dec 4, 2024
39 checks passed
@cstuncsik cstuncsik deleted the pay-2074-typeerror-_bmain-is-undefined branch December 4, 2024 10:05
@github-actions github-actions bot mentioned this pull request Dec 4, 2024
@janober
Copy link
Member

janober commented Dec 4, 2024

Got released with [email protected]

riascho pushed a commit that referenced this pull request Jan 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
n8n team Authored by the n8n team Released ui Enhancement in /editor-ui or /design-system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants