Skip to content

Commit

Permalink
fix(editor): Use optional chaining for all members in execution data …
Browse files Browse the repository at this point in the history
…when using the debug feature (#12024)
  • Loading branch information
cstuncsik authored and riascho committed Jan 14, 2025
1 parent e516fb3 commit 19a10d0
Show file tree
Hide file tree
Showing 2 changed files with 75 additions and 6 deletions.
79 changes: 74 additions & 5 deletions packages/editor-ui/src/composables/useExecutionDebugging.test.ts
Original file line number Diff line number Diff line change
@@ -1,14 +1,84 @@
import { createTestingPinia } from '@pinia/testing';
import { setActivePinia } from 'pinia';
import { mockedStore } from '@/__tests__/utils';
import { useWorkflowsStore } from '@/stores/workflows.store';
import { useExecutionDebugging } from './useExecutionDebugging';
import type { INodeUi, IExecutionResponse } from '@/Interface';
import type { Workflow } from 'n8n-workflow';
import { useToast } from '@/composables/useToast';

vi.mock('@/composables/useToast', () => {
const showToast = vi.fn();
return {
useToast: () => ({
showToast,
}),
};
});

let executionDebugging: ReturnType<typeof useExecutionDebugging>;
let toast: ReturnType<typeof useToast>;

describe('useExecutionDebugging()', () => {
beforeEach(() => {
vi.clearAllMocks();
createTestingPinia();
executionDebugging = useExecutionDebugging();
toast = useToast();
});

it('should not throw when runData node is an empty array', async () => {
const mockExecution = {
data: {
resultData: {
runData: {
testNode: [],
},
},
},
} as unknown as IExecutionResponse;

const workflowStore = mockedStore(useWorkflowsStore);
workflowStore.getNodes.mockReturnValue([{ name: 'testNode' }] as INodeUi[]);
workflowStore.getExecution.mockResolvedValueOnce(mockExecution);
workflowStore.getCurrentWorkflow.mockReturnValue({
pinData: {},
getParentNodes: vi.fn().mockReturnValue([]),
} as unknown as Workflow);

await expect(executionDebugging.applyExecutionData('1')).resolves.not.toThrowError();
});

it('should show missing nodes warning toast', async () => {
const mockExecution = {
data: {
resultData: {
runData: {
testNode: [
{
data: {},
},
],
},
},
},
} as unknown as IExecutionResponse;

const workflowStore = mockedStore(useWorkflowsStore);
workflowStore.getNodes.mockReturnValue([{ name: 'testNode2' }] as INodeUi[]);
workflowStore.getExecution.mockResolvedValueOnce(mockExecution);
workflowStore.getCurrentWorkflow.mockReturnValue({
pinData: {},
getParentNodes: vi.fn().mockReturnValue([]),
} as unknown as Workflow);

await executionDebugging.applyExecutionData('1');

expect(workflowStore.setWorkflowExecutionData).toHaveBeenCalledWith(mockExecution);
expect(toast.showToast).toHaveBeenCalledWith(expect.objectContaining({ type: 'info' }));
expect(toast.showToast).toHaveBeenCalledWith(expect.objectContaining({ type: 'warning' }));
});

it('should applyExecutionData', async () => {
setActivePinia(createTestingPinia());
const mockExecution = {
data: {
resultData: {
Expand All @@ -31,10 +101,9 @@ describe('useExecutionDebugging()', () => {
getParentNodes: vi.fn().mockReturnValue([]),
} as unknown as Workflow);

const { applyExecutionData } = useExecutionDebugging();

await applyExecutionData('1');
await executionDebugging.applyExecutionData('1');

expect(workflowStore.setWorkflowExecutionData).toHaveBeenCalledWith(mockExecution);
expect(toast.showToast).toHaveBeenCalledTimes(1);
});
});
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,7 @@ export const useExecutionDebugging = () => {
let pinnings = 0;

pinnableNodes.forEach((node: INodeUi) => {
const nodeData = runData[node.name]?.[0].data?.main?.[0];
const nodeData = runData[node.name]?.[0]?.data?.main?.[0];
if (nodeData) {
pinnings++;
workflowsStore.pinData({
Expand Down

0 comments on commit 19a10d0

Please sign in to comment.