fix(public-api): Fix error updating workflow with property not define…

…d in the schema (#4089) * fix(cli): catch errors on updating workflow * ⚡ Don\'t allow additionalProperties in the workflow schema Co-authored-by: ricardo <[email protected]>
n8n-io · Sep 14, 2022 · f40ae50 · f40ae50
1 parent b2807ce
commit f40ae50
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 1 deletion.
diff --git a/packages/cli/src/PublicApi/v1/handlers/workflows/spec/schemas/workflow.yml b/packages/cli/src/PublicApi/v1/handlers/workflows/spec/schemas/workflow.yml
@@ -1,4 +1,5 @@
 type: object
+additionalProperties: false
 required:
   - name
   - nodes

diff --git a/packages/cli/src/PublicApi/v1/handlers/workflows/workflows.handler.ts b/packages/cli/src/PublicApi/v1/handlers/workflows/workflows.handler.ts
@@ -198,7 +198,13 @@ export = {
 				await workflowRunner.remove(id.toString());
 			}
 
-			await updateWorkflow(sharedWorkflow.workflowId, updateData);
+			try {
+				await updateWorkflow(sharedWorkflow.workflowId, updateData);
+			} catch (error) {
+				if (error instanceof Error) {
+					return res.status(400).json({ message: error.message });
+				}
+			}
 
 			if (sharedWorkflow.workflow.active) {
 				try {