👕 Apply rule node-param-placeholder-miscased-id (#3443)

Co-authored-by: Iván Ovejero <[email protected]>
n8n-io · Jun 3, 2022 · d706e93 · d706e93
1 parent c03ab51
commit d706e93
Show file tree

Hide file tree

Showing 15 changed files with 26 additions and 2 deletions.
diff --git a/.eslintrc.js b/.eslintrc.js
@@ -423,6 +423,7 @@ module.exports = {
 				'n8n-nodes-base/node-param-resource-with-plural-option': 'error',
 				'n8n-nodes-base/node-param-resource-without-no-data-expression': 'error',
 				'n8n-nodes-base/node-param-type-options-missing-from-limit': 'error',
+				'n8n-nodes-base/node-param-placeholder-miscased-id': 'error',
 				'n8n-nodes-base/node-param-description-miscased-url': 'error',
 			},
 		},

diff --git a/packages/nodes-base/nodes/Aws/DynamoDB/ItemDescription.ts b/packages/nodes-base/nodes/Aws/DynamoDB/ItemDescription.ts
@@ -616,6 +616,7 @@ export const itemFields: INodeProperties[] = [
 				displayName: 'Attributes to Select',
 				name: 'projectionExpression',
 				type: 'string',
+				// eslint-disable-next-line n8n-nodes-base/node-param-placeholder-miscased-id
 				placeholder: 'id, name',
 				default: '',
 			},
@@ -709,6 +710,7 @@ export const itemFields: INodeProperties[] = [
 		displayName: 'Key Condition Expression',
 		name: 'keyConditionExpression',
 		description: 'Condition to determine the items to be retrieved. The condition must perform an equality test on a single partition key value, in this format: <code>partitionKeyName = :partitionkeyval</code>',
+		// eslint-disable-next-line n8n-nodes-base/node-param-placeholder-miscased-id
 		placeholder: 'id = :id',
 		default: '',
 		type: 'string',

diff --git a/packages/nodes-base/nodes/CrateDb/CrateDb.node.ts b/packages/nodes-base/nodes/CrateDb/CrateDb.node.ts
@@ -79,6 +79,7 @@ export class CrateDb implements INodeType {
 					},
 				},
 				default: '',
+				// eslint-disable-next-line n8n-nodes-base/node-param-placeholder-miscased-id
 				placeholder: 'SELECT id, name FROM product WHERE quantity > $1 AND price <= $2',
 				required: true,
 				description: 'The SQL query to execute. You can use n8n expressions or $1 and $2 in conjunction with query parameters.',
@@ -123,6 +124,7 @@ export class CrateDb implements INodeType {
 					},
 				},
 				default: '',
+				// eslint-disable-next-line n8n-nodes-base/node-param-placeholder-miscased-id
 				placeholder: 'id,name,description',
 				description: 'Comma-separated list of the properties which should used as columns for the new rows',
 			},

diff --git a/packages/nodes-base/nodes/Google/BigQuery/RecordDescription.ts b/packages/nodes-base/nodes/Google/BigQuery/RecordDescription.ts
@@ -121,6 +121,7 @@ export const recordFields: INodeProperties[] = [
 		},
 		default: '',
 		required: true,
+		// eslint-disable-next-line n8n-nodes-base/node-param-placeholder-miscased-id
 		placeholder: 'id,name,description',
 		description: 'Comma-separated list of the item properties to use as columns',
 	},

diff --git a/...s-base/nodes/Microsoft/GraphSecurity/descriptions/SecureScoreControlProfileDescription.ts b/...s-base/nodes/Microsoft/GraphSecurity/descriptions/SecureScoreControlProfileDescription.ts
@@ -123,6 +123,7 @@ export const secureScoreControlProfileFields: INodeProperties[] = [
 				description: '<a href="https://docs.microsoft.com/en-us/graph/query-parameters#filter-parameter">Query parameter</a> to filter results by',
 				type: 'string',
 				default: '',
+				// eslint-disable-next-line n8n-nodes-base/node-param-placeholder-miscased-id
 				placeholder: 'startsWith(id, \'AATP\')',
 			},
 		],

diff --git a/packages/nodes-base/nodes/Microsoft/Sql/MicrosoftSql.node.ts b/packages/nodes-base/nodes/Microsoft/Sql/MicrosoftSql.node.ts
@@ -98,6 +98,7 @@ export class MicrosoftSql implements INodeType {
 					},
 				},
 				default: '',
+				// eslint-disable-next-line n8n-nodes-base/node-param-placeholder-miscased-id
 				placeholder: 'SELECT id, name FROM product WHERE id < 40',
 				required: true,
 				description: 'The SQL query to execute',
@@ -129,6 +130,7 @@ export class MicrosoftSql implements INodeType {
 					},
 				},
 				default: '',
+				// eslint-disable-next-line n8n-nodes-base/node-param-placeholder-miscased-id
 				placeholder: 'id,name,description',
 				description: 'Comma-separated list of the properties which should used as columns for the new rows',
 			},

diff --git a/packages/nodes-base/nodes/MySql/MySql.node.ts b/packages/nodes-base/nodes/MySql/MySql.node.ts
@@ -74,6 +74,7 @@ export class MySql implements INodeType {
 					},
 				},
 				default: '',
+				// eslint-disable-next-line n8n-nodes-base/node-param-placeholder-miscased-id
 				placeholder: 'SELECT id, name FROM product WHERE id < 40',
 				required: true,
 				description: 'The SQL query to execute',
@@ -110,6 +111,7 @@ export class MySql implements INodeType {
 					},
 				},
 				default: '',
+				// eslint-disable-next-line n8n-nodes-base/node-param-placeholder-miscased-id
 				placeholder: 'id,name,description',
 				description: 'Comma-separated list of the properties which should used as columns for the new rows',
 			},

diff --git a/packages/nodes-base/nodes/Postgres/Postgres.node.ts b/packages/nodes-base/nodes/Postgres/Postgres.node.ts
@@ -72,6 +72,7 @@ export class Postgres implements INodeType {
 					},
 				},
 				default: '',
+				// eslint-disable-next-line n8n-nodes-base/node-param-placeholder-miscased-id
 				placeholder: 'SELECT id, name FROM product WHERE quantity > $1 AND price <= $2',
 				required: true,
 				description: 'The SQL query to execute. You can use n8n expressions or $1 and $2 in conjunction with query parameters.',
@@ -116,6 +117,7 @@ export class Postgres implements INodeType {
 					},
 				},
 				default: '',
+				// eslint-disable-next-line n8n-nodes-base/node-param-placeholder-miscased-id
 				placeholder: 'id:int,name:text,description',
 				// eslint-disable-next-line n8n-nodes-base/node-param-description-miscased-id
 				description: 'Comma-separated list of the properties which should used as columns for the new rows. You can use type casting with colons (:) like id:int.',

diff --git a/packages/nodes-base/nodes/QuestDb/QuestDb.node.ts b/packages/nodes-base/nodes/QuestDb/QuestDb.node.ts
@@ -72,6 +72,7 @@ export class QuestDb implements INodeType {
 					},
 				},
 				default: '',
+				// eslint-disable-next-line n8n-nodes-base/node-param-placeholder-miscased-id
 				placeholder: 'SELECT id, name FROM product WHERE quantity > $1 AND price <= $2',
 				required: true,
 				description: 'The SQL query to execute. You can use n8n expressions or $1 and $2 in conjunction with query parameters.',
@@ -119,6 +120,7 @@ export class QuestDb implements INodeType {
 					},
 				},
 				default: '',
+				// eslint-disable-next-line n8n-nodes-base/node-param-placeholder-miscased-id
 				placeholder: 'id,name,description',
 				description: 'Comma-separated list of the properties which should used as columns for the new rows',
 			},

diff --git a/packages/nodes-base/nodes/QuickBase/RecordDescription.ts b/packages/nodes-base/nodes/QuickBase/RecordDescription.ts
@@ -362,6 +362,7 @@ export const recordFields: INodeProperties[] = [
 		},
 		default: '',
 		required: true,
+		// eslint-disable-next-line n8n-nodes-base/node-param-placeholder-miscased-id
 		placeholder: 'id,name,description',
 		description: 'Comma-separated list of the properties which should used as columns for the new rows',
 	},
@@ -487,6 +488,7 @@ export const recordFields: INodeProperties[] = [
 		},
 		default: '',
 		required: true,
+		// eslint-disable-next-line n8n-nodes-base/node-param-placeholder-miscased-id
 		placeholder: 'id,name,description',
 		description: 'Comma-separated list of the properties which should used as columns for the new rows',
 	},

diff --git a/packages/nodes-base/nodes/Rundeck/Rundeck.node.ts b/packages/nodes-base/nodes/Rundeck/Rundeck.node.ts
@@ -80,7 +80,7 @@ export class Rundeck implements INodeType {
 					},
 				},
 				default: '',
-				placeholder: 'Rundeck Job Id',
+				placeholder: 'Rundeck Job ID',
 				required: true,
 				description: 'The job ID to execute',
 			},
@@ -144,7 +144,7 @@ export class Rundeck implements INodeType {
 					},
 				},
 				default: '',
-				placeholder: 'Rundeck Job Id',
+				placeholder: 'Rundeck Job ID',
 				required: true,
 				description: 'The job ID to get metadata off',
 			},

diff --git a/packages/nodes-base/nodes/Snowflake/Snowflake.node.ts b/packages/nodes-base/nodes/Snowflake/Snowflake.node.ts
@@ -81,6 +81,7 @@ export class Snowflake implements INodeType {
 					},
 				},
 				default: '',
+				// eslint-disable-next-line n8n-nodes-base/node-param-placeholder-miscased-id
 				placeholder: 'SELECT id, name FROM product WHERE id < 40',
 				required: true,
 				description: 'The SQL query to execute',
@@ -117,6 +118,7 @@ export class Snowflake implements INodeType {
 					},
 				},
 				default: '',
+				// eslint-disable-next-line n8n-nodes-base/node-param-placeholder-miscased-id
 				placeholder: 'id,name,description',
 				description: 'Comma-separated list of the properties which should used as columns for the new rows',
 			},

diff --git a/packages/nodes-base/nodes/Stackby/Stackby.node.ts b/packages/nodes-base/nodes/Stackby/Stackby.node.ts
@@ -181,6 +181,7 @@ export class Stackby implements INodeType {
 				},
 				default: '',
 				required: true,
+				// eslint-disable-next-line n8n-nodes-base/node-param-placeholder-miscased-id
 				placeholder: 'id,name,description',
 				description: 'Comma-separated list of the properties which should used as columns for the new rows',
 			},

diff --git a/packages/nodes-base/nodes/Strapi/EntryDescription.ts b/packages/nodes-base/nodes/Strapi/EntryDescription.ts
@@ -83,6 +83,7 @@ export const entryFields: INodeProperties[] = [
 			},
 		},
 		default: '',
+		// eslint-disable-next-line n8n-nodes-base/node-param-placeholder-miscased-id
 		placeholder: 'id,name,description',
 		description: 'Comma-separated list of the properties which should used as columns for the new rows',
 	},
@@ -343,6 +344,7 @@ export const entryFields: INodeProperties[] = [
 			},
 		},
 		default: '',
+		// eslint-disable-next-line n8n-nodes-base/node-param-placeholder-miscased-id
 		placeholder: 'id,name,description',
 		description: 'Comma-separated list of the properties which should used as columns for the new rows',
 	},

diff --git a/packages/nodes-base/nodes/TimescaleDb/TimescaleDb.node.ts b/packages/nodes-base/nodes/TimescaleDb/TimescaleDb.node.ts
@@ -79,6 +79,7 @@ export class TimescaleDb implements INodeType {
 					},
 				},
 				default: '',
+				// eslint-disable-next-line n8n-nodes-base/node-param-placeholder-miscased-id
 				placeholder: 'SELECT id, name FROM product WHERE quantity > $1 AND price <= $2',
 				required: true,
 				description: 'The SQL query to execute. You can use n8n expressions or $1 and $2 in conjunction with query parameters.',
@@ -129,6 +130,7 @@ export class TimescaleDb implements INodeType {
 					},
 				},
 				default: '',
+				// eslint-disable-next-line n8n-nodes-base/node-param-placeholder-miscased-id
 				placeholder: 'id,name,description',
 				description: 'Comma-separated list of the properties which should used as columns for the new rows',
 			},