Skip to content

Commit

Permalink
refactor: Add action to all operations on all nodes (#3655)
Browse files Browse the repository at this point in the history
* 👕 Add `action` to `INodePropertyOptions`

* 👕 Apply `node-param-operation-option-without-action`

* ✏️ Fix add/remove phrasing

* ✏️ Fix email template phrasing

* ✏️ Fix add/remove phrasing

* ✏️ Fix custom fields phrasing

* ✏️ Fix job report phrasing

* ✏️ Fix query phrasing

* ✏️ Various phrasing fixes

* ✏️ Fix final phrasings

* ✏️ Remove `conversation`

* ✏️ Fix plural
  • Loading branch information
ivov authored Jul 10, 2022
1 parent d5d4dd3 commit 6f95121
Show file tree
Hide file tree
Showing 648 changed files with 2,651 additions and 3 deletions.
1 change: 1 addition & 0 deletions .eslintrc.js
Original file line number Diff line number Diff line change
Expand Up @@ -453,6 +453,7 @@ module.exports = {
'n8n-nodes-base/node-param-min-value-wrong-for-limit': 'error',
'n8n-nodes-base/node-param-multi-options-type-unsorted-items': 'error',
'n8n-nodes-base/node-param-operation-without-no-data-expression': 'error',
'n8n-nodes-base/node-param-operation-option-without-action': 'error',
'n8n-nodes-base/node-param-option-description-identical-to-name': 'error',
'n8n-nodes-base/node-param-option-name-containing-star': 'error',
'n8n-nodes-base/node-param-option-name-duplicate': 'error',
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -23,14 +23,17 @@ export const attendanceOperations: INodeProperties[] = [
{
name: 'Create',
value: 'create',
action: 'Create an attendance',
},
{
name: 'Get',
value: 'get',
action: 'Get an attendance',
},
{
name: 'Get All',
value: 'getAll',
action: 'Get all attendances',
},
],
default: 'create',
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -24,14 +24,17 @@ export const eventOperations: INodeProperties[] = [
{
name: 'Create',
value: 'create',
action: 'Create an event',
},
{
name: 'Get',
value: 'get',
action: 'Get an event',
},
{
name: 'Get All',
value: 'getAll',
action: 'Get all events',
},
],
default: 'create',
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -24,18 +24,22 @@ export const personOperations: INodeProperties[] = [
{
name: 'Create',
value: 'create',
action: 'Create a person',
},
{
name: 'Get',
value: 'get',
action: 'Get a person',
},
{
name: 'Get All',
value: 'getAll',
action: 'Get all people',
},
{
name: 'Update',
value: 'update',
action: 'Update a person',
},
],
default: 'create',
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -19,10 +19,12 @@ export const personTagOperations: INodeProperties[] = [
{
name: 'Add',
value: 'add',
action: 'Add a person tag',
},
{
name: 'Remove',
value: 'remove',
action: 'Remove a person tag',
},
],
default: 'add',
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -24,18 +24,22 @@ export const petitionOperations: INodeProperties[] = [
{
name: 'Create',
value: 'create',
action: 'Create a petition',
},
{
name: 'Get',
value: 'get',
action: 'Get a petition',
},
{
name: 'Get All',
value: 'getAll',
action: 'Get all petitions',
},
{
name: 'Update',
value: 'update',
action: 'Update a petition',
},
],
default: 'create',
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -23,18 +23,22 @@ export const signatureOperations: INodeProperties[] = [
{
name: 'Create',
value: 'create',
action: 'Create a signature',
},
{
name: 'Get',
value: 'get',
action: 'Get a signature',
},
{
name: 'Get All',
value: 'getAll',
action: 'Get all signatures',
},
{
name: 'Update',
value: 'update',
action: 'Update a signature',
},
],
default: 'create',
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -23,14 +23,17 @@ export const tagOperations: INodeProperties[] = [
{
name: 'Create',
value: 'create',
action: 'Create a tag',
},
{
name: 'Get',
value: 'get',
action: 'Get a tag',
},
{
name: 'Get All',
value: 'getAll',
action: 'Get all tags',
},
],
default: 'create',
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -20,16 +20,19 @@ export const accountContactOperations: INodeProperties[] = [
name: 'Create',
value: 'create',
description: 'Create an association',
action: 'Create an account contact',
},
{
name: 'Delete',
value: 'delete',
description: 'Delete an association',
action: 'Delete an account contact',
},
{
name: 'Update',
value: 'update',
description: 'Update an association',
action: 'Update an account contact',
},
],
default: 'create',
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -24,26 +24,31 @@ export const accountOperations: INodeProperties[] = [
name: 'Create',
value: 'create',
description: 'Create an account',
action: 'Create an account',
},
{
name: 'Delete',
value: 'delete',
description: 'Delete an account',
action: 'Delete an account',
},
{
name: 'Get',
value: 'get',
description: 'Get data of an account',
action: 'Get an account',
},
{
name: 'Get All',
value: 'getAll',
description: 'Get data of all accounts',
action: 'Get all accounts',
},
{
name: 'Update',
value: 'update',
description: 'Update an account',
action: 'Update an account',
},
],
default: 'create',
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -24,26 +24,31 @@ export const connectionOperations: INodeProperties[] = [
name: 'Create',
value: 'create',
description: 'Create a connection',
action: 'Create a connection',
},
{
name: 'Delete',
value: 'delete',
description: 'Delete a connection',
action: 'Delete a connection',
},
{
name: 'Get',
value: 'get',
description: 'Get data of a connection',
action: 'Get a connection',
},
{
name: 'Get All',
value: 'getAll',
description: 'Get data of all connections',
action: 'Get all connections',
},
{
name: 'Update',
value: 'update',
description: 'Update a connection',
action: 'Update a connection',
},
],
default: 'create',
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -24,26 +24,31 @@ export const contactOperations: INodeProperties[] = [
name: 'Create',
value: 'create',
description: 'Create a contact',
action: 'Create a contact',
},
{
name: 'Delete',
value: 'delete',
description: 'Delete a contact',
action: 'Delete a contact',
},
{
name: 'Get',
value: 'get',
description: 'Get data of a contact',
action: 'Get a contact',
},
{
name: 'Get All',
value: 'getAll',
description: 'Get data of all contact',
action: 'Get all contacts',
},
{
name: 'Update',
value: 'update',
description: 'Update a contact',
action: 'Update a contact',
},
],
default: 'create',
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -20,11 +20,13 @@ export const contactListOperations: INodeProperties[] = [
name: 'Add',
value: 'add',
description: 'Add contact to a list',
action: 'Add a contact to a list',
},
{
name: 'Remove',
value: 'remove',
description: 'Remove contact from a list',
action: 'Remove a contact from a list',
},
],
default: 'add',
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -20,11 +20,13 @@ export const contactTagOperations: INodeProperties[] = [
name: 'Add',
value: 'add',
description: 'Add a tag to a contact',
action: 'Add a contact tag',
},
{
name: 'Remove',
value: 'remove',
description: 'Remove a tag from a contact',
action: 'Remove a contact tag',
},
],
default: 'add',
Expand Down
7 changes: 7 additions & 0 deletions packages/nodes-base/nodes/ActiveCampaign/DealDescription.ts
Original file line number Diff line number Diff line change
Expand Up @@ -28,36 +28,43 @@ export const dealOperations: INodeProperties[] = [
name: 'Create',
value: 'create',
description: 'Create a deal',
action: 'Create a deal',
},
{
name: 'Create Note',
value: 'createNote',
description: 'Create a deal note',
action: 'Create a deal note',
},
{
name: 'Delete',
value: 'delete',
description: 'Delete a deal',
action: 'Delete a deal',
},
{
name: 'Get',
value: 'get',
description: 'Get data of a deal',
action: 'Get a deal',
},
{
name: 'Get All',
value: 'getAll',
description: 'Get data of all deals',
action: 'Get all deals',
},
{
name: 'Update',
value: 'update',
description: 'Update a deal',
action: 'Update a deal',
},
{
name: 'Update Deal Note',
value: 'updateNote',
description: 'Update a deal note',
action: 'Update a deal note',
},
],
default: 'create',
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -24,26 +24,31 @@ export const ecomCustomerOperations: INodeProperties[] = [
name: 'Create',
value: 'create',
description: 'Create a E-commerce Customer',
action: 'Create an e-commerce customer',
},
{
name: 'Delete',
value: 'delete',
description: 'Delete a E-commerce Customer',
action: 'Delete an e-commerce customer',
},
{
name: 'Get',
value: 'get',
description: 'Get data of a E-commerce Customer',
action: 'Get an e-commerce customer',
},
{
name: 'Get All',
value: 'getAll',
description: 'Get data of all E-commerce Customer',
action: 'Get all e-commerce customers',
},
{
name: 'Update',
value: 'update',
description: 'Update a E-commerce Customer',
action: 'Update an e-commerce customer',
},
],
default: 'create',
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -28,26 +28,31 @@ export const ecomOrderOperations: INodeProperties[] = [
name: 'Create',
value: 'create',
description: 'Create a order',
action: 'Create an e-commerce order',
},
{
name: 'Delete',
value: 'delete',
description: 'Delete a order',
action: 'Delete an e-commerce order',
},
{
name: 'Get',
value: 'get',
description: 'Get data of a order',
action: 'Get an e-commerce order',
},
{
name: 'Get All',
value: 'getAll',
description: 'Get data of all orders',
action: 'Get all e-commerce orders',
},
{
name: 'Update',
value: 'update',
description: 'Update a order',
action: 'Update an e-commerce order',
},
],
default: 'create',
Expand Down
Loading

0 comments on commit 6f95121

Please sign in to comment.