Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add common issues to chat trigger node #2607

Conversation

imchairmanm
Copy link
Contributor

No description provided.

Copy link

netlify bot commented Nov 8, 2024

Deploy Preview for n8n-docs ready!

Name Link
🔨 Latest commit f433b61
🔍 Latest deploy log https://app.netlify.com/sites/n8n-docs/deploys/673ce40be470220009716133
😎 Deploy Preview https://deploy-preview-2607--n8n-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

github-actions bot commented Nov 8, 2024

Overall readability score: 44.25 (🟢 +0.02)

File Readability
common-issues.md 65.89 (-)
index.md 71.11 (🔴 -0.61)
View detailed metrics

🟢 - Shows an increase in readability
🔴 - Shows a decrease in readability

File Readability FRE GF ARI CLI DCRS
common-issues.md 65.89 60.85 10.47 10.5 9.81 7.41
  - - - - - -
index.md 71.11 55.44 8.28 10.4 10.61 6.37
  🔴 -0.61 🟢 +0 🔴 -0.06 🟢 +0 🔴 -0.11 🔴 -0.11

Averages:

  Readability FRE GF ARI CLI DCRS
Average 44.25 35.24 11.43 14.7 14.28 8.45
  🟢 +0.02 🟢 +0.02 🟢 +0 🟢 +0 🟢 +0 🟢 +0
View metric targets
Metric Range Ideal score
Flesch Reading Ease 100 (very easy read) to 0 (extremely difficult read) 60
Gunning Fog 6 (very easy read) to 17 (extremely difficult read) 8 or less
Auto. Read. Index 6 (very easy read) to 14 (extremely difficult read) 8 or less
Coleman Liau Index 6 (very easy read) to 17 (extremely difficult read) 8 or less
Dale-Chall Readability 4.9 (very easy read) to 9.9 (extremely difficult read) 6.9 or less

Copy link
Contributor

@nik8n nik8n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TBH I did not fully get the 2nd point. But maybe that is because I did not have the problem yet.

@imchairmanm
Copy link
Contributor Author

@nik8n Yeah, to be honest it's a bit unclear to me too.

I was attempting to try and resolve the conflict between this solution (don't connect them to the same memory buffer node), with what we say here (we recommend that they do connect everything to the same memory buffer node). I'm probably missing something though.

@jeanpaul is this something you could give some insight into?

@jeanpaul
Copy link
Contributor

I wrote this on Notion too:

[The issue that that solution was for] was mostly because they’ve referred to nodes in their memory settings that would (for the chat-trigger) not be available yet. The tricky thing about re-using nodes is that expressions are evaluated (for these sub-nodes) at the root-node where it’s used. So, the same expression can have different values depending on where it’s used.

@imchairmanm imchairmanm merged commit f66645f into main Nov 19, 2024
6 of 7 checks passed
@imchairmanm imchairmanm deleted the DOC-1157/add-common-issues-to-manual-chat-trigger-chat-trigger-node branch November 19, 2024 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants