-
-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use cryptography instead of pycrypto #11
Conversation
Cool, thanks for the contribution! I'm running into an issue installing cryptography with pypy-5.1.1 on OS X. Interestingly, it works fine installing with python3, just has an issue with pypy.
Also unfortunate that cryptography seems to be incompatible with pypy3, though I suppose not a critical issue.
|
Got it -- I'm surprised to see that pypy doesn't seem to improve performance vs python2, though python 2.7.10, using
|
Hey, glad to see you got As for pypy performance gains, what you see is pretty much expected. Pypy provides a JIT which isn't going to get much warm-up time if we are running synthetic benchmarks like Cryptography is fully working with CPython 2-3, and Pypy2. Pypy3 is unfortunately not maintained (as most of their donations go towards maintaining CPython2 compatibility). |
Merged in 7720195. Thank you! |
In order to support pypy, I converted this library over to using the cryptography package. Let me know if you need anything else.