Update naming for a few JRB ship object variables #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few naming updates for JRB ship related object fields.
oShipPart3UnkF4->oShipPart3PitchAdjust: this variable is used to adjust the pitch of the ship to control the rocking behaviour.oShipPart3UnkF8->oShipPart3RollAdjust: this variable is never written to, but it is used to calculate the ship's roll. Seems like the ship was originally intended to roll back and forth in addition to pitching but this idea was scrapped partway through.oJrbSlidingBoxUnkF4->oJrbSlidingBoxShipCenterReference: this field is a reference to theinSunkenShipobject, which the sliding box uses as a parent to keep track of its current position on the ship deck.inSunkenShipis an invisible object inside the floating ship that tracks the ship's overall position, since the tangible ship itself is composed of multiple different sections.