Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify comment about KtQ speed #31

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

briandef
Copy link

(Chatted about this in #help in the discord about a week ago)

The original comment confused me when I was examining KtQ code, because it doesn't matter if Mario finishes the race fairly or finishes the race by cheating, only that he has finishes the race. This is what the code is checking for (oKoopaRaceEndpointRaceStatus!=0 matches both "Mario cheated" and "Mario didn't cheat").

I removed the part about the cannon, since it's implied by finishing the race, and added a line of English to help explain the rest of the conditional

VDavid003 referenced this pull request in VDavid003/sm64-port-android Aug 13, 2020
Merged. Thanks for your contribution!

"Changed amount of sleep frames when transitioning from main menu and exiting a stage to fix TAS sync issues."
MaikelChan pushed a commit to MaikelChan/sm64 that referenced this pull request Oct 19, 2020
DbpGaming pushed a commit to DbpGaming/sm64 that referenced this pull request Nov 15, 2021
Puppycam Incline Look Smoothing
@mountainflaw mountainflaw marked this pull request as ready for review September 2, 2023 23:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants