Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 31 additions & 0 deletions src/use-async-effect.spec.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -359,3 +359,34 @@ it("calls a clenup function returned by the generator when dependencies change",
expect(callable).toHaveBeenCalledTimes(2);
done();
});

it("calls latest generator reference upon dependency change", async done => {
const callable = jest.fn();
let setState: (i: number) => void = () => 1;

const TestComponent: React.FC<{}> = () => {
const [state, _setState] = React.useState(0);
setState = _setState;
useAsyncEffect(
function*() {
yield Promise.resolve();
callable(state);
},
[state]
);
return null;
};

const { unmount } = render(<TestComponent />);
await Promise.resolve();
expect(callable).toHaveBeenCalledWith(0);

act(() => {
setState(1);
});
await Promise.resolve();

expect(callable).toHaveBeenCalledWith(1);
unmount();
done();
});
8 changes: 4 additions & 4 deletions src/use-async-effect.ts
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,10 @@ export const useAsyncEffect = (
) => {
const generatorRef = useRef(createGenerator);

useEffect(() => {
generatorRef.current = createGenerator;
});

useEffect(() => {
let isCanceled = false;
let onCancel = noop;
Expand Down Expand Up @@ -66,8 +70,4 @@ export const useAsyncEffect = (
cleanupHandler();
};
}, deps);

useEffect(() => {
generatorRef.current = createGenerator;
});
};