fix: make the unit tests work under Windows #210
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
How about using / as the separator? It should work with both Windows and *nix |
Pass values using JSON encapsulation via system property. - This removes the need to escape/transform strings - This allows the test to work under Windows, which uses the \ backslash character as the directory separator - This also make the test work in case other special characters are in the path such as ' (quote)
Fiouz
force-pushed
the
fix_Windows_unit_tests
branch
from
a318c9e to
0f88f7f
Compare
|
PR modified to adopt a safer and more generic approach; instead, we use a system property to pass a JSON-encapsulated value around (we rely on Groovy JsonOutput/JsonSlurper):
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Windows uses the \ backslash character as the directory separator, which
interferes with the standard Groovy escaping.