feat: in qlog, also record src/dst addrs and path id for packets #182
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Frando
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This records the path id remote address when sending or receiving packets. This makes debugging iroh much more useful.
qlogdoesn't seem to have fields for this, there's a way to add extra fields however. This uses this. The extra fields are shown in the JSON when clicking on an event in https://qvis.quictools.info/, so this is actually usable this way even though non-standard.Not sure what the best way forward here is, but with this we can now see the path id and src/dst remote addr for each packet when using with iroh.
Edit: The current Qlog draft adds a
tuplefield to record the 4-tuple in the top-level eventhttps://quicwg.org/qlog/draft-ietf-quic-qlog-main-schema.html#name-tuple