fix: force raw codec if requested #644
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Arqu
force-pushed
the
arqu/verify_hash
branch
from
f727613
to
bb82c3e
Compare
Arqu
commented
Dec 22, 2022
| .await; | ||
| assert_eq!(http::StatusCode::OK, res.status()); | ||
| let body = hyper::body::to_bytes(res.into_body()).await.unwrap(); | ||
| let ufs = iroh_unixfs::unixfs::UnixfsNode::decode(&test_setup.root_cid, body).unwrap(); |
There was a problem hiding this comment.
Am slightly confused on how to unpack this further without significantly complicating things.
| // Resolve the root block. | ||
| let (root_cid, loaded_cid) = self.resolve_root(&path, &mut ctx).await?; | ||
| match loaded_cid.source { | ||
| Source::Store(_) => inc!(ResolverMetrics::CacheHit), | ||
| _ => inc!(ResolverMetrics::CacheMiss), | ||
| } | ||
|
|
||
| let codec = Codec::try_from(root_cid.codec()).context("unknown codec")?; | ||
| let codec = match force_raw { | ||
| true => Codec::Raw, |
There was a problem hiding this comment.
this works, but is really misusing the current setup
There was a problem hiding this comment.
but I guess it works for now
|
@dignifiedquire where we at with this? |
dignifiedquire
approved these changes
Jan 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes n0-computer/beetle#98