Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add dev-install xtask #347

Merged
merged 3 commits into from
Oct 14, 2022
Merged

chore: add dev-install xtask #347

merged 3 commits into from
Oct 14, 2022

Conversation

b5
Copy link
Member

@b5 b5 commented Oct 14, 2022

fixes private config in the xtask crate (should be publish = false).

Adds new cargo xtask dev-install that'll copy all binaries to $HOME/.cargo/bin/, which is useful while I'm working on iroh start.

Optionally run cargo xtask dev-install --build to run a build of all binaries first

@b5 b5 self-assigned this Oct 14, 2022
@b5 b5 marked this pull request as ready for review October 14, 2022 20:19
@b5 b5 requested review from Arqu, faassen and ramfox October 14, 2022 20:19
dignifiedquire
dignifiedquire reviewed Oct 14, 2022
View reviewed changes
xtask/src/main.rs Outdated Show resolved Hide resolved
dignifiedquire
dignifiedquire reviewed Oct 14, 2022
View reviewed changes
xtask/src/main.rs Outdated Show resolved Hide resolved
dignifiedquire
dignifiedquire reviewed Oct 14, 2022
View reviewed changes
xtask/src/main.rs Outdated Show resolved Hide resolved
dignifiedquire
dignifiedquire reviewed Oct 14, 2022
View reviewed changes
xtask/src/main.rs Outdated Show resolved Hide resolved
Arqu
Arqu approved these changes Oct 14, 2022
View reviewed changes
Copy link
Collaborator

@Arqu Arqu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx, this is neat

@b5 b5 merged commit 5937924 into main Oct 14, 2022
@dignifiedquire dignifiedquire deleted the b5/xtask_install branch February 20, 2023 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dignifiedquire dignifiedquire dignifiedquire left review comments

@Arqu Arqu Arqu approved these changes

@faassen faassen Awaiting requested review from faassen

@ramfox ramfox Awaiting requested review from ramfox

Assignees

@b5 b5

Labels
None yet
Projects
iroh
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@b5 @dignifiedquire @Arqu