fix(cron): honor profile wrap_response during delivery - #3
Closed
mzkarami wants to merge 4 commits into
Closed
Conversation
🔎 Lint report:
|
| Rule | Count |
|---|---|
unresolved-import |
1 |
First entries
tests/gateway/test_undo_rewind_session.py:13: [unresolved-import] unresolved-import: Cannot resolve imported module `pytest`
✅ Fixed issues: none
Unchanged: 4962 pre-existing issues carried over.
Diagnostics are surfaced as warnings — this check never fails the build.
…p menu (NousResearch#36227) The setup-mode chooser showed two bare labels ('Quick Setup (Nous Portal) — OAuth login, model & messaging' / 'Full setup — configure everything') that didn't explain what Quick Setup actually is. Expand both labels inline so each choice line carries a concise explanation: Quick Setup (Nous Portal) — free OAuth login, no API keys, model + tools Full setup — configure every provider, tool & option yourself (bring your own keys) Single-file change to the choice labels; no new plumbing.
…gnore files (NousResearch#36231) The skill security scanner blocked legitimate community skills on three intrinsic false-positive patterns: - read_secrets_file matched `cat > file.env <<` heredocs (writing the user's own keys into their own local .env), not just `cat file.env` reads. Exclude output redirections. - allowed-tools frontmatter is REQUIRED by the agent-skill spec; every compliant skill declares it. Drop from HIGH privilege_escalation to a LOW informational finding so it no longer drives the verdict. - python_os_environ flagged `os.environ.get("CONFIG_VAR")` config reads as HIGH exfiltration. Exempt non-secret `.get()` reads; add a dedicated CRITICAL python_environ_get_secret pattern so secret-named reads (OPENAI_API_KEY etc.) are still caught. Also: scan_skill() now honors a skill-provided .skillignore / .clawhubignore (gitignore-style) so dev/docs artifacts shipped in a skill root are excluded from both structural checks and pattern scanning. SKILL.md is never ignorable. 80 tests pass (64 existing + 16 new).
…I/TUI) (NousResearch#36699) Gateway /undo was wired into every platform but still ran the old single-turn hard-truncate. Now it matches the CLI/TUI: /undo [N] backs up N user turns (default 1, clamps to oldest), soft-deletes the truncated rows on disk (active=0, kept for audit, hidden from re-prompts and search) via SessionDB.rewind_to_message, evicts the cached agent so the next turn rebuilds from the active-only transcript (the gateway's equivalent of the CLI's in-place history surgery + memory invalidation), and echoes the backed-up message text so the user can copy/edit and resend — platforms have no editable composer to prefill. - gateway/session.py: SessionStore.rewind_session(session_id, n) wraps the soft-delete primitive; load_transcript already returns active-only - gateway/run.py: _handle_undo_command parses [N], calls rewind_session, evicts the agent, echoes target text; confirm-prompt detail is count-aware - locales: undo.removed gains {turns}; new undo.invalid_count, all 16 langs - tests: tests/gateway/test_undo_rewind_session.py (6 cases)
mzkarami
force-pushed
the
auto/nightly-cron-wrap-response-profile-20260601
branch
from
June 1, 2026 09:09
1ee762d to
1f20f80
Compare
mzkarami
pushed a commit
that referenced
this pull request
Jul 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
cron.wrap_responsefrom a cron job's runtime profile during deliverywrap_response: falseTest Plan
uv run --extra dev pytest tests/cron/test_cron_profile.py tests/cron/test_scheduler.py::TestDeliverResultWrapping -quv run --extra dev ruff check cron/scheduler.py tests/cron/test_cron_profile.pygit diff --checkRefs NousResearch#36248