Test bail feature and improve hard-source support #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
mzgoddard
commented
Jun 15, 2017
mzgoddard
commented
- Test bail config and flag
- Better support hard-source by ensuring the compilation cache name is configured
- Support hard-source and self-referencing modules
Since the tests run in child processes it'll be good to run them one by one to make sure they don't starve for resources that could cause them to fail.
- Improve cache name for hard-source to distinguish the compilations with - Add transform dependency when a Module is returned to the EntryReferencePlugin When hard-source or other plugins return a Module during the resolver step of the normal module factory, the EntryReferencePlugin should make sure there is an entry for that file. As well it will add a dependency to the entry to ensure its included. For self-referencing modules instead of returning a reference module return the module directly. With hard-source for self-referencing modules the reference module will not be created. Since the self-referencing module is in the chunk a require directly to it is fine.
72 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.