Fix karma tests #26
Merged
Fix karma tests #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice fix. Thanks! |
|
No problem! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes problem detailed in #25.
Karma's implicit plugin import apparently doesn't always work, but the workaround was to simply list the plugins explicitly in
karma.conf.js.Similarly the
karma-phantomjs-launcherplugin couldn't find thephantomjsmodule. Turns out the plugin hadphantomjslisted as a peer-dependency, butrackt-clididn't fullfill this requirement. I don't see how this ever worked, unless the user hadphantomjsinstalled globally. The solution was to bumpkarma-phantomjs-launcherto a newer version which hasphantomjs-prebuiltas a direct dependency.I successfully ran
npm testinreact-flipcardwith these changes (after fixing the lint errors).