Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2.6.0 TMDb discover & other TMDb special lists #113

Merged
merged 9 commits into from
Nov 13, 2020

Conversation

meisnate12
Copy link

@meisnate12 meisnate12 commented Nov 12, 2020

[2.6.0] - 2020-11-12

Added

Fixed

@burkasaurusrex
Copy link

burkasaurusrex commented Nov 13, 2020

Just went through this quickly - looks like good work to me.

Feature velocity has been incredible @meisnate12! After this merge, should we take a breath on adding features and write tests? I think some unit testing would help stability going forward. I don't know Python that well, but I should be able to help after next week. I think it'll save our sanity as the complexity continues to grow.

@mza921
Copy link
Owner

mza921 commented Nov 13, 2020

I agree on the feature velocity. For everyone claiming not to know Python well, the script is not too shabby! Thanks for all the contributions. I definitely would like to get some unit testing and enhanced logging, followed by performance enhancements.

@mza921 mza921 merged commit f8ce499 into mza921:master Nov 13, 2020
@meisnate12
Copy link
Author

lol this project is the first python code I've ever written, I'm mainly a Java programmer. I was looking at the tmdbv3api and I did a pull there to add trending and had to add my tests that were automatically run it was pretty cool. +1 for actual logging vs just prints. Also, I have been working on creating a dictionary to speed up performance I was going to try and get that working along with the multiple configs for my next release.

@meisnate12
Copy link
Author

@burkasaurusrex I was wondering how to link issues thanks

@meisnate12 meisnate12 deleted the tmdb_discover branch November 13, 2020 05:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants