-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
2.6.0 TMDb discover & other TMDb special lists #113
Conversation
Pulling 2.5.0 Changes
(FYI you can auto-link issues so they close when this is merged: https://docs.github.com/en/free-pro-team@latest/github/managing-your-work-on-github/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword) |
Just went through this quickly - looks like good work to me. Feature velocity has been incredible @meisnate12! After this merge, should we take a breath on adding features and write tests? I think some unit testing would help stability going forward. I don't know Python that well, but I should be able to help after next week. I think it'll save our sanity as the complexity continues to grow. |
I agree on the feature velocity. For everyone claiming not to know Python well, the script is not too shabby! Thanks for all the contributions. I definitely would like to get some unit testing and enhanced logging, followed by performance enhancements. |
lol this project is the first python code I've ever written, I'm mainly a Java programmer. I was looking at the tmdbv3api and I did a pull there to add trending and had to add my tests that were automatically run it was pretty cool. +1 for actual logging vs just prints. Also, I have been working on creating a dictionary to speed up performance I was going to try and get that working along with the multiple configs for my next release. |
@burkasaurusrex I was wondering how to link issues thanks |
[2.6.0] - 2020-11-12
Added
plex_collection
tmdb_company
andtmdb_network
tmdb_discover
tmdb_popular
,tmdb_top_rated
,tmdb_now_playing
Fixed