Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter "max_age" not working for shows? #93

Closed
bigdork opened this issue Nov 5, 2020 · 5 comments · Fixed by #96
Closed

Filter "max_age" not working for shows? #93

bigdork opened this issue Nov 5, 2020 · 5 comments · Fixed by #96

Comments

@bigdork
Copy link

bigdork commented Nov 5, 2020

This same config works for movies, but not for TV.
I also tried replacing all: true with year: 2020 with the same results.
If I remove this section of the config, the rest of the script executes, so I don't think there's any problem with the Plex config.

Config:

  New Releases:
    sort_title: -0 New Releases
    summary: A collection of new shows that have premiered in the last 6 months
    all: true
    filters:
      max_age: 180
...
plex:
  library: TV Shows
  library_type: show   ### 'movie' or 'show' ###
  token: _REDACTED_
  url: https://plexserveraddress
  sync_mode: sync   ### 'sync' or 'append' ###

Output:

| Updating collection: New Releases...
| Sync Mode: sync
| 
|  Collection Filter max_age: 180
| 
| Processing all: 
Traceback (most recent call last):
  File "/opt/scripts/Plex-Auto-Collections/app/plex_auto_collections.py", line 819, in <module>
    update_from_config(config_path, plex, True, args.no_meta, args.no_images)
  File "/opt/scripts/Plex-Auto-Collections/app/plex_auto_collections.py", line 450, in update_from_config
    missing, map = add_to_collection(config_path, plex, m, v, c, map, filters)
  File "/opt/scripts/Plex-Auto-Collections/app/plex_tools.py", line 287, in add_to_collection
    max_age = imdb_tools.regex_first_int(sf[1])
AttributeError: module 'imdb_tools' has no attribute 'regex_first_int'
meisnate12 added a commit to meisnate12/Plex-Auto-Collections-Replacement-Plex-Meta-Manager that referenced this issue Nov 5, 2020
mza921 added a commit that referenced this issue Nov 5, 2020
@mza921 mza921 linked a pull request Nov 5, 2020 that will close this issue
@mza921
Copy link
Owner

mza921 commented Nov 5, 2020

@meisnate12 Still broken...

Traceback (most recent call last):
  File "/opt/scripts/Plex-Auto-Collections/app/plex_auto_collections.py", line 819, in <module>
    update_from_config(config_path, plex, True, args.no_meta, args.no_images)
  File "/opt/scripts/Plex-Auto-Collections/app/plex_auto_collections.py", line 450, in update_from_config
    missing, map = add_to_collection(config_path, plex, m, v, c, map, filters)
  File "/opt/scripts/Plex-Auto-Collections/app/plex_tools.py", line 300, in add_to_collection
    max_age = regex_first_int(sf[1])
TypeError: regex_first_int() missing 1 required positional argument: 'method'

mza921 added a commit that referenced this issue Nov 6, 2020
@bigdork
Copy link
Author

bigdork commented Nov 6, 2020

Version 2.4.5

For TV, no longer crashes but still doesn't work. Seems max_age: it is ignored?
With all: true it attempts to add every show in the library.
With year: 2020 it attempts to add every 2020 TV show.

Config:

  New Releases:
    sort_title: -0 New Releases
    summary: A collection of new shows that have premiered in the last 6 months
    #all: true
    year: 2020
    filters:
      max_age: 180

Output:

| Updating collection: New Releases...
| Sync Mode: sync
|
|  Collection Filter max_age: 180
|
| Processing Plex Search: year(2020)
| Processing Plex Search: year(2020)
| New Releases Collection | + | 100 Humans
| New Releases Collection | + | 50 States of Fright
| New Releases Collection | + | 68 Whiskey
^C

Release Dates:

  • 100 Humans = 2020-03-13
  • 50 States of Fright = 2020-04-06
  • 68 Whiskey = 2020-01-15

@meisnate12
Copy link

all show filters are currently broken will fix soon

meisnate12 added a commit to meisnate12/Plex-Auto-Collections-Replacement-Plex-Meta-Manager that referenced this issue Nov 6, 2020
@meisnate12
Copy link

ok please update to 2.4.6 and try and see if it works now I think I've got it working correctly

@bigdork
Copy link
Author

bigdork commented Nov 9, 2020

Version 2.4.6
max_age: appears to be working properly for TV Shows! Thank you!

@bigdork bigdork closed this as completed Nov 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants