🐛 fix hasSideEffect false negative

mysticatea · Jul 14, 2019 · cb518c7 · cb518c7
1 parent aac472e
commit cb518c7
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 0 deletions.
diff --git a/docs/api/ast-utils.md b/docs/api/ast-utils.md
@@ -363,6 +363,7 @@ The side effect means that it *may* modify a certain variable or object member.
 - `AssignmentExpression`
 - `AwaitExpression`
 - `CallExpression`
+- `ImportExpression`
 - `NewExpression`
 - `UnaryExpression` (`[operator = "delete"]`)
 - `UpdateExpression`

diff --git a/src/has-side-effect.js b/src/has-side-effect.js
@@ -83,6 +83,9 @@ const visitor = Object.freeze(
         FunctionExpression() {
             return false
         },
+        ImportExpression() {
+            return true
+        },
         MemberExpression(node, options, visitorKeys) {
             if (options.considerGetters) {
                 return true