Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't crash when passed a null client id #2

Open
wants to merge 14 commits into
base: master
Choose a base branch
from

Commits on Jul 19, 2014

  1. Don't crash when passed a null client id

    Sometimes a client can get confused, and start sending messages with
    null client ids. This just avoids crashing when that happens.
    zwily committed Jul 19, 2014
    Configuration menu
    Copy the full SHA
    1a609a8 View commit details
    Browse the repository at this point in the history

Commits on Jul 29, 2014

  1. bump redis to 0.11.x

    zwily committed Jul 29, 2014
    Configuration menu
    Copy the full SHA
    4313d71 View commit details
    Browse the repository at this point in the history
  2. prevent a crash when redis servers go away

    You need to provide callbacks to redis commands or else redis will throw
    an error (killing your process) when something goes wrong.
    zwily committed Jul 29, 2014
    Configuration menu
    Copy the full SHA
    e2f6b5f View commit details
    Browse the repository at this point in the history

Commits on Aug 2, 2014

  1. Configuration menu
    Copy the full SHA
    f2cc87d View commit details
    Browse the repository at this point in the history
  2. Fix faye submodule location

    zwily committed Aug 2, 2014
    Configuration menu
    Copy the full SHA
    6a707be View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    bc27fed View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    b02caf4 View commit details
    Browse the repository at this point in the history
  5. Add Travis build icon

    zwily committed Aug 2, 2014
    Configuration menu
    Copy the full SHA
    581f6c3 View commit details
    Browse the repository at this point in the history
  6. Make sure clients only get one copy of each message.

    When a client is subscribed to channels like /foo/* and /foo/bar, and a
    message is published to /foo/bar, the client should only receive *one*
    message. Previously, we were sending the message for every shard each
    subscribed channel lived in. (So if /foo/* was in shard1 and /foo/bar
    was in shard2, the subscriber would get two copies.)
    
    This change collects all the client ids from all shards and only sends
    one message to each client.
    zwily committed Aug 2, 2014
    Configuration menu
    Copy the full SHA
    6365b81 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    83fd18d View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    e9a79dc View commit details
    Browse the repository at this point in the history
  9. Convert some hand-rolled async code to use async library

    Pulled in "async" to help with several cases where we perform several
    operations in parallel, and need a callback at the end.
    zwily committed Aug 2, 2014
    Configuration menu
    Copy the full SHA
    4890e71 View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    896ce7c View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    4c0f9b7 View commit details
    Browse the repository at this point in the history