-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't crash when passed a null client id #2
base: master
Are you sure you want to change the base?
Commits on Jul 19, 2014
-
Don't crash when passed a null client id
Sometimes a client can get confused, and start sending messages with null client ids. This just avoids crashing when that happens.
Configuration menu - View commit details
-
Copy full SHA for 1a609a8 - Browse repository at this point
Copy the full SHA 1a609a8View commit details
Commits on Jul 29, 2014
-
Configuration menu - View commit details
-
Copy full SHA for 4313d71 - Browse repository at this point
Copy the full SHA 4313d71View commit details -
prevent a crash when redis servers go away
You need to provide callbacks to redis commands or else redis will throw an error (killing your process) when something goes wrong.
Configuration menu - View commit details
-
Copy full SHA for e2f6b5f - Browse repository at this point
Copy the full SHA e2f6b5fView commit details
Commits on Aug 2, 2014
-
Configuration menu - View commit details
-
Copy full SHA for f2cc87d - Browse repository at this point
Copy the full SHA f2cc87dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 6a707be - Browse repository at this point
Copy the full SHA 6a707beView commit details -
Configuration menu - View commit details
-
Copy full SHA for bc27fed - Browse repository at this point
Copy the full SHA bc27fedView commit details -
Configuration menu - View commit details
-
Copy full SHA for b02caf4 - Browse repository at this point
Copy the full SHA b02caf4View commit details -
Configuration menu - View commit details
-
Copy full SHA for 581f6c3 - Browse repository at this point
Copy the full SHA 581f6c3View commit details -
Make sure clients only get one copy of each message.
When a client is subscribed to channels like /foo/* and /foo/bar, and a message is published to /foo/bar, the client should only receive *one* message. Previously, we were sending the message for every shard each subscribed channel lived in. (So if /foo/* was in shard1 and /foo/bar was in shard2, the subscriber would get two copies.) This change collects all the client ids from all shards and only sends one message to each client.
Configuration menu - View commit details
-
Copy full SHA for 6365b81 - Browse repository at this point
Copy the full SHA 6365b81View commit details -
Configuration menu - View commit details
-
Copy full SHA for 83fd18d - Browse repository at this point
Copy the full SHA 83fd18dView commit details -
Configuration menu - View commit details
-
Copy full SHA for e9a79dc - Browse repository at this point
Copy the full SHA e9a79dcView commit details -
Convert some hand-rolled async code to use async library
Pulled in "async" to help with several cases where we perform several operations in parallel, and need a callback at the end.
Configuration menu - View commit details
-
Copy full SHA for 4890e71 - Browse repository at this point
Copy the full SHA 4890e71View commit details -
Configuration menu - View commit details
-
Copy full SHA for 896ce7c - Browse repository at this point
Copy the full SHA 896ce7cView commit details -
Enfore clientId timeout in clientExists.
Ported from faye-redis-node, see: https://github.com/jpignata/faye-redis-node/commit/d0bc94086315ddbffbcf68018df4e0019eb3c632
Configuration menu - View commit details
-
Copy full SHA for 4c0f9b7 - Browse repository at this point
Copy the full SHA 4c0f9b7View commit details