scope.$apply-async(resizer) #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jguthmiller
approved these changes
Apr 17, 2019
There was a problem hiding this comment.
Any context as to why it needs $applyAsync? It would just be helpful to have in case it ever gets addressed upstream, especially if the upstream solution ends up being different.
Also, you shouldn't need to merge this PR in order to test it locally. Hit me up if you need any help with that.
|
I can test locally. Just wanting to reference the version number in |
|
Is this a documented issue upstream? If so, should we submit a PR for it? If not, should we submit an issue? I only ask because this seems like an issue that other people might have already ran into. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suppress
$scope.digest already in progresserrors.Changed
scope.$apply(resizer)toscope.$apply-async(resizer)This issue was tangentially related to patrickmarabeas#46 (comment).