Skip to content

Modifiy LatexRenderer.render to wrap data into dict #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Modifiy LatexRenderer.render to wrap data into dict #21

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion rest_framework_latex/renderers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ def render(self, data, accepted_media_type=None, renderer_context=None):
"""
# Get latex
tex = super(LatexRenderer, self).render(
data, accepted_media_type, renderer_context)
{'data': data}, accepted_media_type, renderer_context)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Personally, I'd be keen to not change the expected behaviour when a dictionary is passed - this change will wrap:

data = {
  'key': 'val',
}

into

data = {
  'data': {
    'key': 'value'
  }
}

which would break existing applications depending on the data dictionary being passed verbatim in the template.


# Build tempoary directory
t_dir = tempfile.mkdtemp(prefix='drf_latex_')
Expand Down