Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix parameters serialization for server-side rendering #471

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

mayty
Copy link

@mayty mayty commented Jan 19, 2025

  1. Fixed parameter serialization for arrays, tuples, and maps.
  2. Updated datetime serializer to include microseconds if non-zero (Select datetime accurate to millisecond #306). I realize that it might break the integration for some people and I am open to rolling it back.
  3. Updated GitHub actions a bit because they were failing.

Checklist:

  • Add tests that demonstrate the correct behavior of the change. Tests should fail without the change.
  • Add or update relevant docs, in the docs folder and in code.
  • Ensure PR doesn't contain untouched code reformatting: spaces, etc.
  • Run flake8 and fix issues.
  • Run pytest no tests failed. See https://clickhouse-driver.readthedocs.io/en/latest/development.html.

@mayty mayty marked this pull request as ready for review January 19, 2025 02:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug with array query params
1 participant