Fix TCP keepalive idle_time_sec, interval_sec type

mymarilyn · Apr 23, 2024 · 1adf65d · 1adf65d
1 parent 2b35f97
commit 1adf65d
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/clickhouse_driver/client.py b/clickhouse_driver/client.py
@@ -872,7 +872,7 @@ def from_url(cls, url):
                 except ValueError:
                     parts = value.split(',')
                     kwargs[name] = (
-                        float(parts[0]), float(parts[1]), int(parts[2])
+                        int(parts[0]), int(parts[1]), int(parts[2])
                     )
             elif name == 'client_revision':
                 kwargs[name] = int(value)

diff --git a/docs/features.rst b/docs/features.rst
@@ -579,7 +579,7 @@ You can also specify custom keepalive settings with tuple
 
     .. code-block:: python
 
-        >>> client = Client('localhost', tcp_keepalive=(60.5, 5.1, 2))
+        >>> client = Client('localhost', tcp_keepalive=(60, 5, 2))
 
     .. note::
 

diff --git a/tests/test_client.py b/tests/test_client.py
@@ -280,9 +280,9 @@ def test_tcp_keepalive(self):
         c = Client.from_url('clickhouse://host?tcp_keepalive=true')
         self.assertTrue(c.connection.tcp_keepalive)
 
-        c = Client.from_url('clickhouse://host?tcp_keepalive=10.5,2.5,3')
+        c = Client.from_url('clickhouse://host?tcp_keepalive=10,2,3')
         self.assertEqual(
-            c.connection.tcp_keepalive, (10.5, 2.5, 3)
+            c.connection.tcp_keepalive, (10, 2, 3)
         )
 
     def test_client_revision(self):