Repository navigation
Conversation
… (vllm#58863 commit 514102a) Optional patch, off by default. The GDN state commit replays the accepted tokens forward with the verify step's own decay instead of the closed form, so the committed state matches per-token decoding bit for bit. Same cost. Applies cleanly to the v5.2 image (sha256:76eda2f6...) through run.sh's patch step.
Collaborator
|
Thanks. Our 0.32 image carries #58863 at a head that already includes 514102a, so the exact commit comes in by default there. For the current v5.2 kit, merging this as an opt-in patch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Optional patch, off by default, in the same style as
qsa-logits-workspace: backport of commit 514102a of vllm-project/vllm#58863 (by Juergen Schmied, suggested by @ArtyomITA; the PR is still open upstream).What it changes
One file,
model_executor/layers/mamba/gdn/recoverssm_gdn.py:exp(g), instead ofg;h = fma(c, k, h * decay), instead of the closed forms0 * decay + corr.The committed GDN state is then the per-token state bit for bit. The cost is the same: n loads of c, k and the decay.
The v5.2 image has the closed form (the file in
sha256:76eda2f6...is the pre-514102a version). On a GB10 the closed form fails the PR's bit-identity checks intests/kernels/mamba/test_recoverssm_gdn.py. With this change, 62 of 63 of those tests pass; the remaining one is XPU-only.Tested
run.sh's patch step againstmyllmbox/qwen38-flash-next-vllm:v5.2(digest76eda2f6...): the file is copied out of the image, the dry run passes, the patch applies, and the result compiles inside the image.To try it: