Skip to content

ci(prompt): add a linter coverage check to the aftermath phase - #32

Merged
eilandert merged 2 commits into
mainfrom
ci/prompt-linter-coverage-step
Aug 10, 2026
Merged

eilandert merged 2 commits into
mainfrom
ci/prompt-linter-coverage-step

Conversation

@eilandert

Copy link
Copy Markdown
Member

Prompt-only change to ci/PROMPT.md. No code, workflow or test is touched.

TL;DR

The adoption job's closing checklist tells the agent to install a lint hook, but never asks whether the linters behind that hook actually cover the repository. A tree can pass every gate while an entire language in it goes unread, or while a linter runs only its default rule subset.

Adds aftermath step 57, "Check linter coverage: languages and rules", between the commit-hook setup and the review steps, and renumbers the former steps 57–63 to 58–64.

Severity: Low (process — closes a blind spot in the adoption checklist)

What the step asks for

Three checks, each with an evidence-based not-applicable escape:

  • Languages — enumerate tracked file types, map each to the linter that reads it, close every gap by registering the tool in ci/linter/run-all.sh and the pre-commit config.
  • Rules — compare each linter's enabled rule set against the tool's full set, since the default profile is normally a subset; suppressions are justified inline rather than by disabling a category.
  • Blind spots — a linter that never reaches a path is not coverage; its file selection has to match the paths it is meant to guard.

Acceptance is a file type → linter → rule profile table, with fixes landing in PR4 alongside the other aftermath work.

Renumbering

Former 57–63 become 58–64. Updated in step order along with every cross-reference: the phase table and PR table (55–63 → 55–64), the checklist line, the phase-7 preamble, the forwarding section, steps 55–58 → steps 55–59 for the fix-scope note, and both step 62 residue cross-references → step 63.

Testing

Docs-only. ci/linter/run-all.sh staged mode and the pre-commit hooks ran clean on the commit; codespell was the only lens with a file to read. No renumbered step reference remains unadjusted — verified by grepping every step NN and NN–NN range in the file.

New aftermath step verifies every tracked language has a linter and
that each linter runs the rules it needs, not just its default subset.
Renumbers the following aftermath steps 57-63 to 58-64.
@coderabbitai

coderabbitai Bot commented Aug 10, 2026 •

Copy link
Copy Markdown

Review Change Stack

Warning

Review limit reached

@eilandert, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 52 minutes

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: e069d296-51a7-43c8-bd70-895302284f6b

📥 Commits

Reviewing files that changed from the base of the PR and between 1f77fa6 and 77f18cc.

📒 Files selected for processing (1)
  • ci/PROMPT.md

Walkthrough

The CI adoption prompt expands Phase 7 from 9 to 10 aftermath steps. It adds a linter coverage audit and renumbers the review, analysis, coverage, residue, and gitlink checks.

Changes

CI adoption prompt

Layer / File(s) Summary
Phase 7 scope and references
ci/PROMPT.md
Phase 7, PR4, the run plan, snapshot comparison, and forwarding instructions now reference steps 55–64.
Aftermath audit and validation sequence
ci/PROMPT.md
New step 57 audits language and linter coverage. Existing review, timing, dynamic-analysis, coverage, residue, and gitlink checks move to steps 58–64.

Possibly related PRs

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely describes the added linter coverage check in the aftermath phase.
Description check ✅ Passed The description accurately explains the documentation change, added checks, renumbering, scope, and validation.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch ci/prompt-linter-coverage-step
✨ Simplify code
  • Create PR with simplified code
  • Commit simplified code in branch ci/prompt-linter-coverage-step

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2


ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: d80b80dd-0043-4244-b445-075e03848bab

📥 Commits

Reviewing files that changed from the base of the PR and between a8d4ab9 and 1f77fa6.

📒 Files selected for processing (1)
  • ci/PROMPT.md

Comment thread ci/PROMPT.md
Comment thread ci/PROMPT.md Outdated
The new aftermath step left four document-wide references stating 63
steps and a 1-63 range, so an operator following the header would stop
before step 64.

The languages probe used 'sed s/.*\.//', which discards directory
context. The linter inventory selects on paths, so that histogram cannot
distinguish .github/workflows/*.yml from any other YAML and drops the 25
extensionless tracked files (.githooks/pre-commit, config, Dockerfile)
that path-scoped selectors exist to cover. Replaced with an awk probe
that keeps full paths and groups extensionless basenames separately.
@eilandert
eilandert merged commit a8572a1 into main Aug 10, 2026
14 checks passed
@eilandert
eilandert deleted the ci/prompt-linter-coverage-step branch August 10, 2026 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant