Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat/ux-fix-sms-credits #3

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

feat/ux-fix-sms-credits #3

wants to merge 4 commits into from

Conversation

jmcruz14
Copy link
Contributor

This PR updates the settings to enable the updating of SMS/Email credentials for custom providers.

🔧 fix: Add email field to membership organization details
🔧 fix: Add defaultFrom field to system provider details
🔧 fix: Add emailConfig fields to provider details
🔧 fix: Add isEditing prop to EmailProviderForm and SMSProviderForm components
The UI for email and SMS provider settings has been improved to provide a better user experience. The email field has been added to the membership organization details to provide more information about the organization. The defaultFrom field has been added to the system provider details to provide more information about the system provider. The emailConfig fields have been added to the provider details to provide more information about the provider. The isEditing prop has been added to the EmailProviderForm and SMSProviderForm components to allow for editing of the forms.
@jmcruz14 jmcruz14 self-assigned this Oct 19, 2023
@github-actions
Copy link

github-actions bot commented Oct 19, 2023

Visit the preview URL for this PR (updated for commit 52daf82):

https://mycure-prm--preview-jsmkf7we.web.app

(expires Wed, 29 Nov 2023 03:15:21 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 475d6ddac108531a36075a0890b157825f0d9327

…il and SMS provider selection

🔧 fix(SettingsEmail.vue, SettingsSMS.vue): correct data binding for radio buttons and provider details
The UI/UX for selecting email and SMS providers has been improved to provide a more intuitive and user-friendly experience. Radio buttons are now correctly bound to the selected provider, allowing users to easily switch between system and custom providers. Provider details are now correctly displayed, including the provider's logo, label, and backend configuration. The changes also include the addition of an 'Edit' and 'Delete' option for custom providers, and a 'Buy more credits' button for both system and custom providers. This enhances the overall user experience by providing more control and information to the user.
…tter null checking

🔧 refactor(providers.js): add subscription ref to keep track of subscription data
🔧 refactor(providers.js): add senderNo to defaultSystemProvider for better SMS handling
🔧 refactor(providers.js): add subscription value assignment after fetching subscription data
🔧 refactor(providers.js): change creditsCount calculation to include consumed credits
🔧 refactor(providers.js): add upsellSubscription function to handle subscription upgrades
🔧 refactor(providers.js): refactor topupProvider function to handle credit top-ups and limit checks
🔧 refactor(providers.js): add subscription to returned object for external access

📦 feat(CreditPurchaseDialog.vue): add new component for handling credit purchases

🔧 refactor(SettingsEmail.vue): import CreditPurchaseDialog component
🔧 refactor(SettingsEmail.vue): add creditsDialog ref for handling credit purchase dialog
🔧 refactor(SettingsEmail.vue): add openCreditsDialog function to handle opening of credit purchase dialog
🔧 refactor(SettingsEmail.vue): add processPurchase function to handle credit purchase processing
🔧 refactor(SettingsEmail.vue): add event listener for purchase event from CreditPurchaseDialog component
🔧 refactor(SettingsEmail.vue): add disabled attribute to Buy more credits button for system provider
🔧 refactor(SettingsEmail.vue): add default value for systemProvider's defaultFrom

🔧 refactor(SettingsSMS.vue): import CreditPurchaseDialog component
🔧 refactor(SettingsSMS.vue): add creditsDialog ref for handling credit purchase dialog
🔧 refactor(SettingsSMS.vue): add openCreditsDialog function to handle opening of credit purchase dialog
🔧 refactor(SettingsSMS.vue): add processPurchase function to handle credit purchase processing
🔧 refactor(SettingsSMS.vue): add event listener for purchase event from CreditPurchaseDialog component
🔧 refactor(SettingsSMS.vue): add disabled attribute to Buy more credits button for system provider
🔧 refactor(SettingsSMS.vue): add default value for provider's senderNo or defaultFrom

The changes were made to improve the handling of credit purchases and subscription upgrades. The addition of the CreditPurchaseDialog component allows users to purchase credits directly from the settings page. The refactoring of the topupProvider function in providers.js now handles credit top-ups and checks if the new credit amount exceeds the maximum limit. The addition of the upsellSubscription function handles subscription upgrades
…etails

🐛 fix(providers.js): replace hardcoded 'sms' type with dynamic type variable
✨ feat(ConversationInputForm.vue): add credit purchase dialog and credit count display
🔨 refactor(EmailProviderForm.vue, SMSProviderForm.vue, WorkflowForm.vue): improve form labels and layout for better user experience
🔥 refactor(SettingsSMS.vue): remove unnecessary console warning

The unused function getMembershipDetails in membership.js was commented out to clean up the code. In providers.js, the hardcoded 'sms' type was replaced with a dynamic type variable to make the function more flexible and reusable. In ConversationInputForm.vue, a credit purchase dialog and a display for the remaining credit count were added to provide users with a way to purchase more credits and keep track of their usage. The form labels and layout in EmailProviderForm.vue, SMSProviderForm.vue, and WorkflowForm.vue were improved for a better user experience. An unnecessary console warning in SettingsSMS.vue was removed to clean up the console output.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant