feat: allow generic observer #118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the use case is to allow a custom control loop without REST api, and embedded custom monitoring.
|
🤔 I'm guessing you made some modifications based on turn-server? Since turn-server is only available as a bin project and not as an external library to be called by third parties, limiting the types to turn-server wouldn't be much of a problem, and eliminating traits would help rust with type derivation. But it doesn't hurt, and if you're using turn-server as a lib to provide business for your project, there's nothing wrong with modifying to a trait constraint. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the use case is to allow a custom control loop without REST api, and embedded custom monitoring.